Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] npm publish/pack not including all the files with v10.9.2 #8209

Open
2 tasks done
ashishpm opened this issue Apr 4, 2025 · 1 comment
Open
2 tasks done

[BUG] npm publish/pack not including all the files with v10.9.2 #8209

ashishpm opened this issue Apr 4, 2025 · 1 comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps

Comments

@ashishpm
Copy link

ashishpm commented Apr 4, 2025

Is there an existing issue for this?

  • I have searched the existing issues

This issue exists in the latest npm version

  • I am using the latest npm

Current Behavior

When I use npm v10.9.2 and run npm publish or npm pack not all the files and folders are included

npm notice Tarball Contents
npm notice 6.3kB CHANGELOG.md
npm notice 7.1kB README.md
npm notice 2.4kB dist/azureMonitor/amsMetrics.d.ts
npm notice 3.0kB dist/azureMonitor/amsMetrics.js
npm notice 339B dist/azureMonitor/resourceResolver.d.ts
npm notice 385B dist/azureMonitor/resourceResolver.js
npm notice 8.9kB dist/common/builder.d.ts
npm notice 15.8kB dist/common/builder.js
npm notice 4.6kB dist/common/interceptors.d.ts
npm notice 11.3kB dist/common/interceptors.js
npm notice 16.0kB dist/common/logger.d.ts
npm notice 18.4kB dist/common/logger.js
npm notice 2.7kB dist/common/middleware.d.ts
npm notice 10.5kB dist/common/middleware.js
npm notice 1.0kB dist/common/monitor.d.ts
npm notice 3.7kB dist/common/monitor.js
npm notice 1.4kB dist/index.d.ts
npm notice 2.8kB dist/index.js
npm notice 3.5kB dist/logger.d.ts
npm notice 8.3kB dist/logger.js
npm notice 4.7kB dist/metrics.d.ts
npm notice 8.3kB dist/metrics.js
npm notice 160B dist/streams/debug.d.ts
npm notice 500B dist/streams/debug.js
npm notice 5.3kB dist/streams/geneva/index.d.ts
npm notice 15.1kB dist/streams/geneva/index.js
npm notice 1.2kB dist/streams/geneva/master.d.ts
npm notice 3.6kB dist/streams/geneva/master.js
npm notice 514B dist/streams/geneva/options.d.ts
npm notice 1.5kB dist/streams/geneva/options.js
npm notice 298B dist/streams/geneva/stdout.d.ts
npm notice 2.0kB dist/streams/geneva/stdout.js
npm notice 395B dist/streams/geneva/types.d.ts
npm notice 1.9kB dist/streams/geneva/types.js
npm notice 144B dist/streams/prettyPrint.d.ts
npm notice 5.0kB dist/streams/prettyPrint.js
npm notice 205B dist/types.d.ts
npm notice 177B dist/types.js
npm notice 136B dist/utility/environment.d.ts
npm notice 1.7kB dist/utility/environment.js
npm notice 311B dist/utility/format.d.ts
npm notice 3.2kB dist/utility/format.js
npm notice 363B dist/utility/request.d.ts
npm notice 3.9kB dist/utility/request.js
npm notice 2.4kB package.json

Expected Behavior

But with npm v9.5.1 it works as expected and every file is included

npm notice === Tarball Contents ===
npm notice 6.3kB CHANGELOG.md
npm notice 7.1kB README.md
npm notice 2.4kB dist/azureMonitor/amsMetrics.d.ts
npm notice 3.0kB dist/azureMonitor/amsMetrics.js
npm notice 339B dist/azureMonitor/resourceResolver.d.ts
npm notice 385B dist/azureMonitor/resourceResolver.js
npm notice 8.9kB dist/common/builder.d.ts
npm notice 15.8kB dist/common/builder.js
npm notice 4.6kB dist/common/interceptors.d.ts
npm notice 11.3kB dist/common/interceptors.js
npm notice 16.0kB dist/common/logger.d.ts
npm notice 18.4kB dist/common/logger.js
npm notice 2.7kB dist/common/middleware.d.ts
npm notice 10.5kB dist/common/middleware.js
npm notice 1.0kB dist/common/monitor.d.ts
npm notice 3.7kB dist/common/monitor.js
npm notice 1.4kB dist/index.d.ts
npm notice 2.8kB dist/index.js
npm notice 3.5kB dist/logger.d.ts
npm notice 8.3kB dist/logger.js
npm notice 4.7kB dist/metrics.d.ts
npm notice 8.3kB dist/metrics.js
npm notice 9.2kB dist/schemas/common.d.ts
npm notice 29.2kB dist/schemas/common.js
npm notice 751B dist/schemas/e2e.d.ts
npm notice 2.1kB dist/schemas/e2e.js
npm notice 3.7kB dist/schemas/index.d.ts
npm notice 1.4kB dist/schemas/index.js
npm notice 2.8kB dist/schemas/usertest.d.ts
npm notice 10.1kB dist/schemas/usertest.js
npm notice 6.6kB dist/schemas/ux-renderer.d.ts
npm notice 20.0kB dist/schemas/ux-renderer.js
npm notice 160B dist/streams/debug.d.ts
npm notice 500B dist/streams/debug.js
npm notice 5.3kB dist/streams/geneva/index.d.ts
npm notice 15.1kB dist/streams/geneva/index.js
npm notice 1.2kB dist/streams/geneva/master.d.ts
npm notice 3.6kB dist/streams/geneva/master.js
npm notice 514B dist/streams/geneva/options.d.ts
npm notice 1.5kB dist/streams/geneva/options.js
npm notice 298B dist/streams/geneva/stdout.d.ts
npm notice 2.0kB dist/streams/geneva/stdout.js
npm notice 395B dist/streams/geneva/types.d.ts
npm notice 1.9kB dist/streams/geneva/types.js
npm notice 144B dist/streams/prettyPrint.d.ts
npm notice 5.0kB dist/streams/prettyPrint.js
npm notice 205B dist/types.d.ts
npm notice 177B dist/types.js
npm notice 136B dist/utility/environment.d.ts
npm notice 1.7kB dist/utility/environment.js
npm notice 311B dist/utility/format.d.ts
npm notice 3.2kB dist/utility/format.js
npm notice 363B dist/utility/request.d.ts
npm notice 3.9kB dist/utility/request.js
npm notice 2.4kB package.json

As you can see from the logs above that the dist/schemas folder is not included in v10.9.2

Steps To Reproduce

I am attaching the .npmignore and .gitignore files

.gitignore :

# Modules
node_modules/

# Built files
coverage/
.*/
*.tgz
*.log
*.txt
dist/
src/schemas/

.npmignore:

Modules

node_modules/

Unnecessary built files

coverage/
.*/
*.tgz
*.log
*.txt

Source files

src/
schemas/
*.json
!package.json
build.js

Test files

dist/test/
.spec.
**/*.map

Also the schemas folder is available in dist folder.

Environment

  • npm: 10.9.2
  • Node.js: 20.14
  • OS Name: Windows 11
@ashishpm ashishpm added Bug thing that needs fixing Needs Triage needs review for next steps labels Apr 4, 2025
@milaninfy
Copy link
Contributor

Between npm@9, npm@10 there are changes which are related to packing and file inclusion. Please provide reproduction case with package.json as fields like files in package.json can impact the packing, logs, configs, etc to understand this issue better and to conclude if it's an bug/error or wrong usage/expectation of npm pack/publish command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps
Projects
None yet
Development

No branches or pull requests

2 participants