Merge pull request #195 from nova-rey/codex/fix25-prompt-20251225-2011-20

Codex: fix25.prompt.md

Author: nova-rey

build/installer-initramfs/init

@@ -53,6 +53,10 @@ sp_log() {
     printf '[SP-INSTALLER] %s\n' "$@" >>"$SP_LOG_DEVICE" 2>&1
 }
 
+sp_log_warn() {
+    sp_log "$@"
+}
+
 sp_trim() {
     printf '%s' "$1" | sed 's/^[[:space:]]*//;s/[[:space:]]*$//'
 }
@@ -574,6 +578,9 @@ sp_load_filesystem_modules() {
 
 sp_bootstrap() {
     PATH=/bin:/sbin:/usr/bin:/usr/sbin
+    if [ -n "${SP_PREPEND_PATH:-}" ]; then
+        PATH="${SP_PREPEND_PATH}:${PATH}"
+    fi
     export PATH
 
     # BusyBox setup (best-effort).

build/installer-initramfs/runtime/lib/rescue_mode.sh

@@ -21,6 +21,10 @@ sp_rescue_log_line() {
     printf '[SP-RESCUE] %s\n' "$*" >>"$SP_RESCUE_LOG_DEVICE" 2>/dev/null || true
 }
 
+sp_rescue_log_noninteractive_skip() {
+    printf '[SP-INSTALLER][WARN] rescue noninteractive; skipping shell\n' >&2
+}
+
 sp_rescue_write_header() {
     sp_rescue_log_line "state=rescue" "result=enter" "reason=${1:-unknown}"
     sp_rescue_log_line "==== SP RESCUE MODE ===="
@@ -211,7 +215,21 @@ sp_enter_rescue_mode() {
     console_path="${SP_TEST_RESCUE_CONSOLE:-${SP_RESCUE_CONSOLE:-/dev/console}}"
     shell_path="$(sp_rescue_find_shell || true)"
 
+    rescue_noninteractive=0
+    if [ "${SP_RESCUE_FORCE_INTERACTIVE:-0}" != "1" ]; then
+        if [ ! -t 0 ]; then
+            rescue_noninteractive=1
+        fi
+        if [ "${SP_RESCUE_NONINTERACTIVE:-0}" = "1" ]; then
+            rescue_noninteractive=1
+        fi
+    fi
+
     if [ -n "${shell_path:-}" ]; then
+        if [ "${rescue_noninteractive:-0}" -eq 1 ]; then
+            sp_rescue_log_noninteractive_skip
+            return 1
+        fi
         rescue_loop="${SP_TEST_RESCUE_LOOP:-1}"
         sp_rescue_log_line "state=rescue" "note=launching-shell" "shell=${shell_path}" "console=${console_path}"
         first_loop=1

build/installer-initramfs/runtime/lib/storage_bootstrap.sh

@@ -92,7 +92,26 @@ sp_bootstrap_usb_storage() {
     for host in /sys/class/scsi_host/host*; do
         [ -d "$host" ] || continue
         scan="${host}/scan"
-        printf '%s\n' "- - -" > "$scan" 2>/dev/null || true
+        [ -e "$scan" ] || continue
+        if [ ! -w "$scan" ]; then
+            sp_log_warn \
+                "state=storage-bootstrap" \
+                "phase=scsi-scan" \
+                "result=warn" \
+                "reason=scan-not-writable" \
+                "scan=${scan}"
+            continue
+        fi
+
+        if ! printf '%s\n' "- - -" > "$scan" 2>/dev/null; then
+            sp_log_warn \
+                "state=storage-bootstrap" \
+                "phase=scsi-scan" \
+                "result=warn" \
+                "reason=scan-write-failed" \
+                "scan=${scan}"
+            continue
+        fi
     done
 
     sp_bootstrap_usb_storage_run_test_trigger

dist/initrd-installer.img

@@ -53,6 +53,10 @@ sp_log() {
     printf '[SP-INSTALLER] %s\n' "$@" >>"$SP_LOG_DEVICE" 2>&1
 }
 
+sp_log_warn() {
+    sp_log "$@"
+}
+
 sp_trim() {
     printf '%s' "$1" | sed 's/^[[:space:]]*//;s/[[:space:]]*$//'
 }
@@ -574,6 +578,9 @@ sp_load_filesystem_modules() {
 
 sp_bootstrap() {
     PATH=/bin:/sbin:/usr/bin:/usr/sbin
+    if [ -n "${SP_PREPEND_PATH:-}" ]; then
+        PATH="${SP_PREPEND_PATH}:${PATH}"
+    fi
     export PATH
 
     # BusyBox setup (best-effort).

docs/AGENT_RUNS/codex-run-20251225-2011-21.md

@@ -92,7 +92,26 @@ sp_bootstrap_usb_storage() {
     for host in /sys/class/scsi_host/host*; do
         [ -d "$host" ] || continue
         scan="${host}/scan"
-        printf '%s\n' "- - -" > "$scan" 2>/dev/null || true
+        [ -e "$scan" ] || continue
+        if [ ! -w "$scan" ]; then
+            sp_log_warn \
+                "state=storage-bootstrap" \
+                "phase=scsi-scan" \
+                "result=warn" \
+                "reason=scan-not-writable" \
+                "scan=${scan}"
+            continue
+        fi
+
+        if ! printf '%s\n' "- - -" > "$scan" 2>/dev/null; then
+            sp_log_warn \
+                "state=storage-bootstrap" \
+                "phase=scsi-scan" \
+                "result=warn" \
+                "reason=scan-write-failed" \
+                "scan=${scan}"
+            continue
+        fi
     done
 
     sp_bootstrap_usb_storage_run_test_trigger