Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PR reviews #39

Open
mrousavy opened this issue Mar 12, 2021 · 1 comment
Open

Support PR reviews #39

mrousavy opened this issue Mar 12, 2021 · 1 comment

Comments

@mrousavy
Copy link

Hi! Awesome action, thanks!

Have you considered also supporting PR reviews?

Instead of hiding the comment in the "Changed files" section, this also starts a review and posts it in the conversation, e.g.:

image

@xiongchiamiov
Copy link

One way to do this would be to hook up the linter to reviewdog; then the framework handles all the different logic for things like github reviews and all this code needs to do is run the translation layer between reviewdog and swiftlint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants