Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking only Files in PR - .swiftlint.yml is not respected #32

Open
ben-ole opened this issue Oct 2, 2020 · 1 comment
Open

Checking only Files in PR - .swiftlint.yml is not respected #32

ben-ole opened this issue Oct 2, 2020 · 1 comment

Comments

@ben-ole
Copy link

ben-ole commented Oct 2, 2020

When using the configuration option

env:
 - name: SwiftLint
      uses: norio-nomura/[email protected]
      env:
        DIFF_BASE: ${{ github.base_ref }}
      with:
        args: --strict

in order to check only files of the current PR, my .swiftlint.yml configuration (containing some exclusion filters) is not taken into account.

Removing the line DIFF_BASE: ${{ github.base_ref }} re-enables my .swiftlint.yml configuration.

@thibault-carpentier
Copy link

If found that adding
--config YOUR_SWIFTLINT_PATH.yml on the args: comments helps with this issue.

However, I cannot seem to have the action only scan PR only files with this. Hope this helps!

PSchmiedmayer added a commit to Apodini/Apodini that referenced this issue Jan 17, 2021
Remove that only diffs are checked and therefore the .swiiftlint.yml file ist respected (norio-nomura/action-swiftlint#32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants