Thanks for the bitmaps function. I am using it!
Just ran into something that could use some attention.
In the new function
void ssd1306_bitmaps(SSD1306_t * dev, int xpos, int ypos, uint8_t * bitmap, int width, int height, bool invert)
The xpos, ypos and height parameters are in pixels. I suggest either changing the parameter width to mean width in pixels, or renaming it so that it is clear that it is pixels/8.
Also, the ImageDemo example calls
ssd1306_bitmaps(&dev, xpos, ypos, batman, 4, 12, false);
It passes the height as 12, but the image in the array batman[] is 13 pixels heigh.
/Coert
Thanks for the bitmaps function. I am using it!
Just ran into something that could use some attention.
In the new function
The
xpos,yposandheightparameters are in pixels. I suggest either changing the parameterwidthto mean width in pixels, or renaming it so that it is clear that it is pixels/8.Also, the
ImageDemoexample callsIt passes the height as
12, but the image in the arraybatman[]is 13 pixels heigh./Coert