Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | versioning | concurrency retry number for put_object is squared #8831

Open
nadavMiz opened this issue Feb 26, 2025 · 0 comments
Open
Labels

Comments

@nadavMiz
Copy link
Contributor

Environment info

  • NooBaa Version: VERSION
  • Platform: Kubernetes 1.14.1 | minikube 1.1.1 | OpenShift 4.1 | other: specify

we have concurrency retry for both move_to_dest and move_to_dest_version. that means that when move_to_dest_version retries are exhausted we will throw the error to move_to_dest where its retry mechanism will catch the error and call move_to_dest_version again. meaning the actual retry number is config.NSFS_RENAME_RETRIES * config.NSFS_RENAME_RETRIES. we should probably move the retry mechanism of move_to_dest to catch only versioning disabled path. we might need to increase the default retry number config.NSFS_RENAME_RETRIES

Actual behavior

  1. retry number is squared

Expected behavior

  1. after retries are exhausted we should throw

Steps to reproduce

  1. constantly throw a retry-able error in move_to_dest_version

More information - Screenshots / Logs / Other output

@nadavMiz nadavMiz added the NS-FS label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant