File tree 1 file changed +10
-3
lines changed
1 file changed +10
-3
lines changed Original file line number Diff line number Diff line change @@ -429,15 +429,22 @@ class NamespaceGCP {
429
429
//////////
430
430
// ACLs //
431
431
//////////
432
-
432
+ /*
433
+ NooBaa does not support ACLs - not for buckets, nor objects.
434
+ However, some S3 clients fail to function entirely without a valid response to execution of ACL operations.
435
+ Thus, we opted to implement a faux-support for the operation - enough to allow the clients to work, but still without supporting ACLs.
436
+ The reason that read_object_md() is used, is to allow potential errors to rise up if necessary -
437
+ for example, if the user tries to interact with an object that does not exist, the operation would fail as expected with NoSuchObject.
438
+ */
433
439
async get_object_acl ( params , object_sdk ) {
434
440
dbg . log0 ( 'NamespaceGCP.get_object_acl:' , this . bucket , inspect ( params ) ) ;
435
- throw new S3Error ( S3Error . NotImplemented ) ;
441
+ await this . read_object_md ( params , object_sdk ) ;
442
+ return s3_utils . DEFAULT_OBJECT_ACL ;
436
443
}
437
444
438
445
async put_object_acl ( params , object_sdk ) {
439
446
dbg . log0 ( 'NamespaceGCP.put_object_acl:' , this . bucket , inspect ( params ) ) ;
440
- throw new S3Error ( S3Error . NotImplemented ) ;
447
+ await this . read_object_md ( params , object_sdk ) ;
441
448
}
442
449
443
450
///////////////////
You can’t perform that action at this time.
0 commit comments