Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python errors don't propagate back to the user #104

Open
thilinarmtb opened this issue Nov 23, 2022 · 1 comment
Open

Python errors don't propagate back to the user #104

thilinarmtb opened this issue Nov 23, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@thilinarmtb
Copy link
Contributor

thilinarmtb commented Nov 23, 2022 •
edited
Loading

Seems like the Python failures (and exceptions) as well as failures in the backend don't
get propagated back to libnomp. Instead, libnomp kernels just prints the wrong answer.
This has to be fixed.
@thilinarmtb thilinarmtb added the enhancement New feature or request label Nov 24, 2022
@poorna2152
Copy link
Contributor

  • We can always print the error in the nomp_set_log function and let the user know that there is a error. Is that okay?
  • I guess there are certain cases where the execution doesn't halt even when there are errors from the Python side. (In NOMP programs that I wrote even with loopy transformation errors the program continued and exited in the normal routine which shouldn't happen). This also needs to be addressed here right?

@thilinarmtb thilinarmtb changed the title Backend errors and Python errors don't propagate back to the user Python errors don't propagate back to the user May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thilinarmtb @poorna2152