Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Type to Search" #419

Open
1 task done
amminadabz opened this issue Dec 12, 2024 · 6 comments · May be fixed by #437
Open
1 task done

Add "Type to Search" #419

amminadabz opened this issue Dec 12, 2024 · 6 comments · May be fixed by #437
Labels
enhancement New feature or request

Comments

@amminadabz
Copy link

amminadabz commented Dec 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the solution you'd like

Add "type to search" in the convention of native gnome apps. One should be able to start typing without clicking the search button and have this start a search of running apps/processes.

@amminadabz amminadabz added the enhancement New feature or request label Dec 12, 2024
@nokyan
Copy link
Owner

nokyan commented Dec 14, 2024

Hi, thanks for the issue.
I'll look into how to do it, shouldn't be too difficult I hope.

@nokyan
Copy link
Owner

nokyan commented Jan 28, 2025

I've implemented typo to search, do you mind testing it?

@dolwup
Copy link

dolwup commented Jan 28, 2025

@nokyan I'm not the issue creator but I just tested it.
It works in the "Apps" view but not the "Processes" view.
Another thing I noticed: after switching to another view (like Processes or any of the hardware monitors) and back the sidebar has focus and type to search does not work until you click on anything in the Apps list

@amminadabz
Copy link
Author

Just built from the search-bar branch. I got it to work in both the Apps and Processes view. Just a couple weird things:

  • The search bar is not automatically dismissed when you change to a different view and come back, even if the bar was empty. I'm not sure if there's a standard for that particular behavior, but Gnome Software has it dismiss every time you change views. Might just be a matter of taste.
  • Search results are sorted alphabetically rather than by relevance to the search term (see screenshots)
  • I am also having the issue where type to search doesn't work after you change views.

Image
Image

@amminadabz
Copy link
Author

Actually now that I look at it, it's not quite alphabetical order. I don't know what dbus-daemon is doing down there at the bottom.

@nokyan
Copy link
Owner

nokyan commented Jan 29, 2025

Thank you for testing.

The search bar is not automatically dismissed when you change to a different view and come back, even if the bar was empty. I'm not sure if there's a standard for that particular behavior, but Gnome Software has it dismiss every time you change views. Might just be a matter of taste.

I'll look into it.

Search results are sorted alphabetically rather than by relevance to the search term (see screenshots)

That's on purpose, I personally don't like when searches like that are sorted by some obscure relevance metric. Your Processes view wasn't alphabetically sorted because you set it to sort by memory usage.

I am also having the issue where type to search doesn't work after you change views.

I haven't yet found out how to fix that. Using grab_focus() on the content stack after the views change doesn't do anything. I'll have to keep trying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants