Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to suppress vulnerability warnings #132

Open
mhdawson opened this issue Mar 2, 2022 · 2 comments
Open

Ability to suppress vulnerability warnings #132

mhdawson opened this issue Mar 2, 2022 · 2 comments

Comments

@mhdawson
Copy link
Contributor

mhdawson commented Mar 2, 2022

A concrete case. One of our top level modules referenced in the ref arch depends on a module which then depends on a module.. which in terms depends on https://www.npmjs.com/package/opencollective. That module uses and old version of node-fetch that is reported as having a high vulnerability.

Looking at the module and what it does it's clearly not an issue.

@richardlau did you have any thoughts about how we might have an exclude list when you did the original work on the vulnerability checks?

@richardlau
Copy link
Contributor

I didn't do the original work on the vulnerability checks, that was @aalykiot (I did fix them when the endpoint we were connecting to changed when npm and GitHub merged their databases).

Could we use something like https://www.npmjs.com/package/npm-audit-resolver? Is there anything in the pipeline from the package maintenance team?

@mhdawson
Copy link
Contributor Author

mhdawson commented Mar 2, 2022

@richardlau thanks for the clarification. I'd looked at who did recent changes and could not quite remember.

I like the suggestion to use https://www.npmjs.com/package/npm-audit-resolver. The collaboration space on that front from the package maintenance team has stalled out. Getting some hands on experience using npm-audit-resolver seems like a good thing on its own as well. The key question I guess is how/what integration with npcheck would look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants