ws2812_effects expects GRB led strip, so RGB led strip colors are off

[NorthernMan54]

Make sure you read and understand http://nodemcu.readthedocs.io/en/dev/en/support/.
Use one of the two templates below and DELETE THE REST.

8<------------------------ BUG REPORT -----------------------------------------

Expected behavior

ws2812_effects like halloween, fire display correct color

Actual behavior

ws2812_effects halloween displays as blue and green

Test code

Provide a Minimal, Complete, and Verifiable example which will reproduce the problem.

-- add code here

I looked at the source and it appears to hard coded as GRB, rather than having an option to declare RGB or GRB.

nodemcu-firmware/app/modules/ws2812_effects.c

Line 587 in c708828

int g1 = 50 * state->brightness / 255;

NodeMCU version

Which branch are you on? If you know the Git revision then add it here as well.

I presume master as of Sept 15, 2018

NodeMCU custom build by frightanic.com
branch: master
commit: c708828
SSL: false
modules: bit,color_utils,crypto,file,gpio,mdns,net,node,pwm,sjson,tmr,uart,websocket,wifi,ws2812,ws2812_effects
build created on 2018-10-15 23:42
powered by Lua 5.1.4 on SDK 2.2.1(6ab97e9)

Hardware

Describe which ESP8266 device you use and document any special hardware setup
required to reproduce the problem.

Nodemcu connected to RGB LED Strip

https://github.com/NorthernMan54/homebridge-mculed/blob/master/nodemcu/README.md

8<------------------------ END BUG REPORT -------------------------------------

[HHHartmann]

There are also other types of color coding like for the APA102 module it is ABGR. "A" being the Intensity Level.
Would be nice to be able to use the effects for all kind of LED strips.
Maybe also rename the Module then.

[marcelstoer]

Maybe @skycoders is willing to pick this up.

[skycoders]

@HHHartmann @NorthernMan54 can you tell me which stripes you use? I have thought about the APA102 stripes but that requires some more abstraction and refactoring. With respect to WS2812 stripes, I have not seen ones which use a different coloring scheme so far, so I'd be interested in knowing which one you are using. Providing a configurable color order for the WS2812 protocol should be rather easy to do.

[NorthernMan54]

The strips I’m using are these https://www.amazon.com/Tape-Light-Foot-Light-Lengths/dp/B01LXTUJ3M The original controller supplied with these have failed, and am in the process of building an ESP8266 based replacement controller.

…

On Oct 31, 2018, at 8:29 AM, Konrad Hübner ***@***.***> wrote: @HHHartmann @NorthernMan54 can you tell me which stripes you use? I have thought about the APA102 stripes but that requires some more abstraction and refactoring. With respect to WS2812 stripes, I have not seen ones which use a different coloring scheme so far, so I'd be interested in knowing which one you are using. Providing a configurable color order for the WS2812 protocol should be rather easy to do. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[skycoders]

ok, I have never seen stripes with that order but there are other reports for e.g. FastLED where people faced the same issue. I will see what I can do, time is a bit limited at the moment... keep you updated.

[NorthernMan54]

Tks Konrad I have worked around these, so no rush. Tks again

…

Sent from my iPad

On Nov 2, 2018, at 2:51 AM, Konrad Hübner ***@***.***> wrote: ok, I have never seen stripes with that order but there are other reports for e.g. FastLED where people faced the same issue. I will see what I can do, time is a bit limited at the moment... keep you updated. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[HHHartmann]

@NorthernMan54 May I ask how you worked around this issue? I'm facing the same problem now.

[konradhuebner]

@HHHartmann sorry I just don't find the time to generalize this. The easy way is to simply set the colors different. The API assumes that the pixel order processed by the strip is GRB, what most WS2812 strips do. If your strip requires RGB order, then simply swap the colors when handing them over to the effects API. It should then result in the correct colors being shown

[HHHartmann]

Thanx for the reply. Your suggestions works where a color can be given, But not for the fire effect. But I looked at the code and found that the fire mode is the same as the flicker mode with preset parameters for color and flicker amount.

[NorthernMan54]

I just didn’t use those functions with the colour functions.

…

On Jul 16, 2019, at 3:46 PM, Gregor Hartmann ***@***.***> wrote: Thanx for the reply. Your suggestions works where a color can be given, But not for the fire effect. But I looked at the code and found that the fire mode is the same as the flicker mode with preset parameters for color and flicker amount. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[HHHartmann]

Will be fixed by #3122 and #3158

[NorthernMan54]

Tks @HHHartmann