-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase timeouts for test/issue-3346.js #3970
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Matteo Collina <[email protected]>
cc @targos |
It still fails on my mac:
I can try to debug a bit after lunch |
This reverts commit 5241094.
It fails because the expected error doesn't happen ( |
It works if I only increase the last timeout. I pushed some changes, but I don't know if the test is still valid that way. |
There's something wrong with the test, I think. Even with 2 seconds, it fails (less often, but still) |
Is it possible that the issue is not timing-related, but due to another test that has some unintended side-effect? |
Note that the timeout before the try/catch can be removed and the test will still pass if run in isolation. |
Then let's remove that. Timing tests are flaky by nature unfortunately :(. We can 100% skip this in CITGM and other envs. |
Fixes #3969