Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/issue-3356.js very flaky when run with test runner #3969

Open
targos opened this issue Dec 21, 2024 · 5 comments · May be fixed by #3970
Open

test/issue-3356.js very flaky when run with test runner #3969

targos opened this issue Dec 21, 2024 · 5 comments · May be fixed by #3970
Labels
good first issue Good for newcomers

Comments

@targos
Copy link
Member

targos commented Dec 21, 2024

Reproduce with npm run test:unit. It almost fails every time on my machine (MacBook M2 Pro).
This makes undici fail CITGM runs.
@targos
Copy link
Member Author

targos commented Dec 21, 2024

Failure is a timeout:

✖ test/issue-3356.js (30002.591792ms)
  'test timed out after 30000ms'

@mcollina
Copy link
Member

I think we should skip this in citgm (when process.env.CITGM is set).

That specific test has been flaky even here, I guess there might be something to investigate.

@mcollina mcollina added the good first issue Good for newcomers label Dec 22, 2024
@mcollina
Copy link
Member

Tagged good first issue for skipping

@targos
Copy link
Member Author

targos commented Dec 22, 2024

It's not specific to citgm. It fails very consistently on my own machine, just by running npm run test:unit

@targos
Copy link
Member Author

targos commented Dec 22, 2024

Note that it only times out if run with other tests. I cannot reproduce by running node test/issue-3356.js directly.

@mcollina mcollina linked a pull request Dec 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

increase timeouts for test/issue-3346.js nodejs/undici
2 participants
@mcollina @targos