sqlite: support ArrayBuffer and TypedArray in StatementSync
#56385
+68
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
himself65
force-pushed
the
himself65/20241228/fix
branch
from
79ca6ef to
aa1218f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56385 +/- ##
=======================================
Coverage 88.53% 88.54%
=======================================
Files 657 657
Lines 190689 190691 +2
Branches 36597 36598 +1
=======================================
+ Hits 168826 168842 +16
+ Misses 15030 15025 -5
+ Partials 6833 6824 -9
|
himself65
commented
Dec 29, 2024
| @@ -1035,7 +1036,8 @@ bool StatementSync::BindValue(const Local<Value>& value, const int index) { | |||
| statement_, index, *val, val.length(), SQLITE_TRANSIENT); | |||
| } else if (value->IsNull()) { | |||
| r = sqlite3_bind_null(statement_, index); | |||
| } else if (value->IsUint8Array()) { | |||
cjihrig
approved these changes
Dec 29, 2024
anonrig
approved these changes
Dec 29, 2024
jasnell
reviewed
Dec 29, 2024
| @@ -930,7 +930,8 @@ bool StatementSync::BindParams(const FunctionCallbackInfo<Value>& args) { | |||
| int anon_idx = 1; | |||
| int anon_start = 0; | |||
|
|
|||
| if (args[0]->IsObject() && !args[0]->IsUint8Array()) { | |||
| if (args[0]->IsObject() && !args[0]->IsUint8Array() && | |||
| !args[0]->IsTypedArray() && !args[0]->IsArrayBuffer()) { | |||
There was a problem hiding this comment.
Using IsArrayBufferView() here is likely a lot better than separate IsUint8Array() and IsTypedArray() checks.
jasnell
reviewed
Dec 29, 2024
| } | ||
|
|
||
| const arrayBuffer = new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8]).buffer; | ||
| const TypedArrays = [ |
There was a problem hiding this comment.
Should DataView also be supported?
aduh95
reviewed
Dec 30, 2024
Comment on lines
+1039
to
+1040
| } else if (value->IsUint8Array() || value->IsArrayBufferView() || | ||
| value->IsArrayBuffer()) { |
There was a problem hiding this comment.
Uint8Arrays are BufferViews
Suggested change
| } else if (value->IsUint8Array() || value->IsArrayBufferView() || | |
| value->IsArrayBuffer()) { | |
| } else if (value->IsArrayBufferView() || value->IsArrayBuffer()) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #56384