-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move action to a different package, and call is-my-node-vulnerable
API from it.
#22
Comments
There were some discussions about moving GitHub Actions to it's own package in a different issue |
I think we can just move Could you confirm @UlisesGascon? |
Why do we need to use I tried to reduce duplicate code, and remove |
GitHub Actions won’t install dependencies so they recommend bundling and committing the bundled code. In fact, GitHub actions don’t use npm at all, they just reference repos and tags. |
I've to find out how to not copy the cache when running ncc in #29 |
Is your feature request related to a problem? Please describe.
The module
is-my-node-vulnerable
is designed to be a CLI/API as well as GitHub Action.The consumers of CLI/API need to download GitHub Action specific dependencies, like
@actions/core
which they don't needhttps://github.com/RafaelGSS/is-my-node-vulnerable/blob/050a05a0798054e069bd305e866a84e326bba558/package.json#L30
Describe the solution you'd like
Move action to a different package, and call
is-my-node-vulnerable
API from it.Additional context
Discussion on Twitter: https://x.com/trivikram/status/1848096860755435622
The text was updated successfully, but these errors were encountered: