Skip to content

Conversation

@avivkeller
Copy link
Member

@avivkeller avivkeller commented Apr 22, 2024

Updates the stalebot with a shorter stale-time, more detailed message, and uses v9.0.0.

@avivkeller
Copy link
Member Author

It's extremely important that these are tested before merge. I didn't do a full test, as I don't have the resources, but they should get one.

@gireeshpunathil
Copy link
Member

60 days seem to be very aggressive to me. 180 days looks reasonable.

@preveen-stack
Copy link
Contributor

Previous discussion on this #4270

@avivkeller
Copy link
Member Author

60 days seem to be very aggressive to me. 180 days looks reasonable.

I feel like, if nothing has happened with your issue in 60 days, chances are nothing will occur with it. I think 180 is too long, maybe 90?

@gireeshpunathil
Copy link
Member

@redyetidev - given:

  • work in help repo is voluntery
  • people's working pattern can be variadic

it is possible that some volunteer get some time after one or two months and decides to make spend some quality time to help with a number of issues. I do that occasionally.

@avivkeller
Copy link
Member Author

I'm happy with changing it to 180 for now, if you'd like.

@avivkeller
Copy link
Member Author

I'll squash and merge, etc, later today

@avivkeller
Copy link
Member Author

I deleted the second file as I feel it's an issue for a different PR. If you'd like me to squash LMK.

@avivkeller
Copy link
Member Author

BTW, @gireeshpunathil,

This PR also upped the operation count to 500, which matches the Node.js repo, and will make the bot more effective.

@avivkeller
Copy link
Member Author

Squashed

@gireeshpunathil gireeshpunathil merged commit b3dcd29 into nodejs:main May 6, 2024
@imidg1825

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants