chore(deps): update eslint to 9.22.0 (#676)

update @yarnpkg/eslint-config to 3.0.0

fix fixable eslint formatting errors

add @typescript-eslint/no-unused-vars caughtErrors:none

change VScode setting to eslint.useFlatConfig true

Author: MikeMcC399

.vscode/settings.json

@@ -4,7 +4,7 @@
     "**/.yarn": true,
     "**/.pnp.*": true
   },
-  "eslint.experimental.useFlatConfig": true,
+  "eslint.useFlatConfig": true,
   "eslint.nodePath": ".yarn/sdks",
   "typescript.enablePromptUseWorkspaceTsdk": true,
   "editor.codeActionsOnSave": {

eslint.config.mjs

@@ -13,11 +13,13 @@ export default [
   ...yarnpkg,
   {
     rules: {
-      // eslint-disable-next-line @typescript-eslint/naming-convention
       'no-restricted-globals': [`error`, {
         name: `fetch`,
         message: `Use fetch from sources/httpUtils.ts`,
       }],
+      '@typescript-eslint/no-unused-vars': [`error`, {
+        caughtErrors: `none`,
+      }],
     },
   },
 ];

package.json

@@ -23,14 +23,14 @@
     "@types/proxy-from-env": "^1",
     "@types/semver": "^7.1.0",
     "@types/which": "^3.0.0",
-    "@yarnpkg/eslint-config": "^2.0.0",
+    "@yarnpkg/eslint-config": "^3.0.0",
     "@yarnpkg/fslib": "^3.0.0-rc.48",
     "@zkochan/cmd-shim": "^6.0.0",
     "better-sqlite3": "^11.7.2",
     "clipanion": "patch:clipanion@npm%3A3.2.1#~/.yarn/patches/clipanion-npm-3.2.1-fc9187f56c.patch",
     "debug": "^4.1.1",
     "esbuild": "^0.25.0",
-    "eslint": "^8.57.0",
+    "eslint": "^9.22.0",
     "proxy-from-env": "^1.1.0",
     "semver": "^7.6.3",
     "supports-color": "^10.0.0",

sources/specUtils.ts

@@ -58,15 +58,15 @@ export function parseSpec(raw: unknown, source: string, {enforceExactVersion = t
 
 type CorepackPackageJSON = {
   packageManager?: string;
-  devEngines?: { packageManager?: DevEngineDependency };
+  devEngines?: {packageManager?: DevEngineDependency};
 };
 
 interface DevEngineDependency {
   name: string;
   version: string;
-  onFail?: 'ignore' | 'warn' | 'error';
+  onFail?: `ignore` | `warn` | `error`;
 }
-function warnOrThrow(errorMessage: string, onFail?: DevEngineDependency['onFail']) {
+function warnOrThrow(errorMessage: string, onFail?: DevEngineDependency[`onFail`]) {
   switch (onFail) {
     case `ignore`:
       break;
@@ -151,7 +151,7 @@ interface FoundSpecResult {
   type: `Found`;
   target: string;
   getSpec: () => Descriptor;
-  range?: Descriptor & {onFail?: DevEngineDependency['onFail']};
+  range?: Descriptor & {onFail?: DevEngineDependency[`onFail`]};
   envFilePath?: string;
 }
 export type LoadSpecResult =

sources/types.ts

@@ -71,7 +71,7 @@ export interface DownloadSpec {
  */
 export interface Config {
   definitions: {
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+
     [name in SupportedPackageManagers]?: {
       /**
        * Defines the version that needs to be used when running commands within

tests/_registryServer.mjs

@@ -79,7 +79,7 @@ const registry = {
   __proto__: null,
   yarn: [`1.9998.9999`],
   pnpm: [`1.9998.9999`],
-  // eslint-disable-next-line @typescript-eslint/naming-convention
+
   '@yarnpkg/cli-dist': [`5.9999.9999`],
   customPkgManager: [`1.0.0`],
 };
@@ -131,7 +131,6 @@ const server = createServer((req, res) => {
   const packageName = req.url.slice(1, slashPosition === -1 ? undefined : slashPosition);
   if (packageName in registry) {
     if (req.url === `/${packageName}`) {
-      // eslint-disable-next-line @typescript-eslint/naming-convention
       res.end(JSON.stringify({"dist-tags": {
         latest: registry[packageName].at(-1),
       }, versions: Object.fromEntries(registry[packageName].map(version =>