Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.js latest CITGM results #1086

Open
targos opened this issue Dec 23, 2024 · 4 comments
Open

Node.js latest CITGM results #1086

targos opened this issue Dec 23, 2024 · 4 comments

Comments

@targos
Copy link
Member

targos commented Dec 23, 2024

Run for v22.x: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3527/
@targos
Copy link
Member Author

targos commented Dec 23, 2024 •
edited
Loading

macOS failures: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3527/nodes=osx11/#showFailuresLink

@merceyz merceyz mentioned this issue Dec 23, 2024
Merged
3 tasks
@merceyz
Copy link
Member

merceyz commented Dec 23, 2024

@yarnpkg/cli /cc @arcanis @merceyz @paul-soporan @larixer (looks like a test is broken by the unflagging of require(esm))

Thanks for the ping, should be fixed by yarnpkg/berry#6639.

@targos targos changed the title Node.js latests CITGM results Node.js latest CITGM results Dec 24, 2024
@liuxingbaoyu
Copy link

Thanks for the mention!
I investigated and the problem comes from https://github.com/babel/babel/blob/02063cd528b8865a578c378a3da619a7a6e2b6d4/jest.config.js#L3-L9 not enabling includePrerelease causes not matching 22.12.1-pre.
I don't understand why the test passed before.
Looks like we need to change more.
For example Image

@liuxingbaoyu liuxingbaoyu mentioned this issue Dec 24, 2024
Merged
@targos
Copy link
Member Author

targos commented Dec 28, 2024

New run for bufferutil which was just released yesterday: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/1699/

arcanis pushed a commit to yarnpkg/berry that referenced this issue Dec 28, 2024
@merceyz
fix(pnp): support require(esm) (#6639)
3978649 
**What's the problem this PR addresses?**

Node.js supports `require(esm)` now so we can avoid throwing an error if
support is enabled.

Fixes #6336
Ref nodejs/citgm#1086

**How did you fix it?**

Avoid throwing `ERR_REQUIRE_ESM` if `process.features.require_module` is
truthy.

**Checklist**
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).
- [x] I have set the packages that need to be released for my changes to
be effective.
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@targos @merceyz @liuxingbaoyu