-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog changes #568
Comments
Reasonably often we change our mind on the semverity of a commit after it has landed. In theory, that shouldn't happen, but if semverity was hard-coded into the commit message it becomes immutable. Is making semverity immutable what is being considered, or am I reading too much into that bullet point? |
@sam-github the goal is not to make it immutable. It's to tie semverity to individual commits rather than to entire pull requests. Often a pull request adds a feature or a breaking change in one commit, but other commits do not deserve to be marked minor or major in the changelog (e.g. test changes, or many of the commits that we do in V8 upgrades) |
I understand its not the goal to make it immutable, but it would be a side-effect. I agree that having semverity associated with entire PRs instead of individual commits also has problems. Its too bad git notes x don't have better support in git and GitHub, they would be ideal for recording this kind of occaisonally mutable metadata. |
In the last release meeting (#564) we discussed altering the layout of our changelogs.
The text was updated successfully, but these errors were encountered: