-
-
Notifications
You must be signed in to change notification settings - Fork 327
[BUG] failed to load zls activated in nix-shell #3063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Probly related to this "--prefix" line extraWrapperArgs = builtins.concatStringsSep " " (
(optional (
config.extraPackages != [ ]
) ''--prefix PATH : "${lib.makeBinPath config.extraPackages}"'')
++ (optional config.wrapRc ''--add-flags -u --add-flags "${initFile}"'')
); |
I think this is effectively a duplicate of #2893. Note that neither Nixvim abruptly switching from prefix to suffix would be a potentially disruptive breaking change, as many users will be expecting the executables installed by nixvim to take priority in vim's PATH. In general, allowing the impure environment to take priority on the PATH sounds like a bad idea, although for LSPs it is often what is desired. Up until now, we have advised setting the relevant I think we need to do a bit of head scratching, and come up with a way to define both overrides (prefix) and fallbacks (suffix). |
I think adding an attribute to indicate prefix/suffix makes sense for this code base, almost every maintainers put it highly on "backward compatibility", nobody wants be flooded by complaints. It's quite alike #2893, but this is for the LSPs, maybe a future PR can closes these two.
It does not sound like a bad idea to me, that exactly what I want. |
lsp
24.11
24.11
master
Description
I use zig and zls (0.13.0) on my system, but for some reason I have projects developed in zig (0.14.0) which is managed in flake.nix, but zls (0.13.0) is always loaded instead of zls (0.14.0).
Minimal, Reproducible Example (MRE)
project flake.nix
project flake.lock
Additional Informations
zls-0.13.0 comes first, echo $PATH in neovim:
The text was updated successfully, but these errors were encountered: