Replies: 1 comment
-
I would just use Otherwise this sounds good to me. No need to wait, we'll decide on the version when it comes time to release. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Following up on the question in open-dicom/csa_header#10 about the relationship between csa_header and NiBabel - I think we should add
csa_headeras an optional dependency.Why?
Our current CSA parser works, but
csa_headeris significantly better:Since Matthew is involved in both projects and the dependencies align (both need numpy + pydicom), this seems like a natural fit.
How?
Use the existing
optional_package()pattern with an adapter for format compatibility:Key points:
NIBABEL_USE_LEGACY_CSA=1for debuggingChanges needed:
csa_header >=1.0.2,<2.0todicomextra in pyproject.tomlCsaHeaderAdapterclass (~100 lines) to convert formatsread()to dispatcher, rename current to_read_legacy()Migration Timeline
Not proposing to remove the legacy parser anytime soon - just make the new one available:
This gives users 2+ years to transition if we go that route.
Questions
csa_header's relationship to the project?Beta Was this translation helpful? Give feedback.
All reactions