Skip to content

Dependency on older version of Ninject.Web.Common #44

@hahschaa

Description

@hahschaa

If I open the .nuspec file in the nuget package, I see this:

<dependencies>
  <dependency id="Ninject" version="[3.2.0.0, 3.3.0.0)" />
  <dependency id="Ninject.Web.Common" version="[3.2.0.0, 3.3.0.0)" />
</dependencies>

However, the latest version of Ninject.Web.Common is 3.3.2. The latest version of Ninject is 3.3.6.
Those all work together perfectly fine, but yields a warning:

warning NU1608: Detected package version outside of dependency constraint: Ninject.Extensions.Wcf 3.2.0 requires Ninject.Web.Common (>= 3.2.0 && < 3.3.0) but version Ninject.Web.Common 3.3.2 was resolved.

I think this should be resolved by changing the requirement to have 3.2.0.0 as the lower bound, without any upper bound. The Ninject dependency can be removed because it is already a dependency of Ninject.Web.Common, so it is transitive.

I wanted to open a PR to fix this, but it seems like the package is build by hand? I don't see any .nuspec file, and packing the project from visual studio give a whole other result.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions