remove sub-env and move locals rewrite to a separate pass #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The approach of creating child environment comes from the time where CPS has to manually track scope. Nowadays we use the information that is in the AST itself, so this is no longer necessary.
Since we are now storing all locals in a single `Env`, we can move the locals to env rewrite outside of annotate, which saves us a lot of processing time (due to reduced re-iteration of the same ast). Testing with cpstest shows a compile-time reduction from 74.760s to 50.019s (33% improvement).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing with cpstest shows a compile-time reduction from 74.760s to
50.019s (33% improvement).