Not compiling on windows

[Milerius]

Hello, this package doesn't seem's to compile on Windows:

CC: libzip_all
Error: execution of an external compiler program 'clang.exe -c  -w -DWIN32_LEAN_AND_MEAN -IC:\Users\roman\Documents\vcpkg/installed/x64-windows/include  -IC:\Users\roman\Desktop\nim-1.0.4\lib -IC:\Users\roman\CLionProjects\atomicDEX-QT\atomic_dex_desktop\tools -o C:\Users\roman\nimcache\dependencies_d\libzip_all.c.o C:\Users\roman\.nimble\pkgs\zip-0.2.1\zip\private\libzip_all.c' failed with exit code: 1

C:\Users\roman\.nimble\pkgs\zip-0.2.1\zip\private\libzip_all.c:193:17: error: function cannot return function type 'int (void *, void *, size_t, enum zip_source_cmd)' (aka 'int (void *, void *, unsigned long long, enum zip_source_cmd)')
typedef ssize_t (*zip_source_callback)(void *state, void *data,
                ^
C:\Users\roman\.nimble\pkgs\zip-0.2.1\zip\private\libzip_all.c:226:29: error: function cannot return function type 'ssize_t' (aka 'int (int *)')
ZIP_EXTERN ssize_t zip_fread(struct zip_file *, void *, size_t);
                            ^
C:\Users\roman\.nimble\pkgs\zip-0.2.1\zip\private\libzip_all.c:505:5: error: unknown type name 'zip_source_callback'
    zip_source_callback f;
    ^
C:\Users\roman\.nimble\pkgs\zip-0.2.1\zip\private\libzip_all.c:719:9: error: use of undeclared identifier 'pid_t'
        pid_t pid;
        ^
C:\Users\roman\.nimble\pkgs\zip-0.2.1\zip\private\libzip_all.c:727:9: error: use of undeclared identifier 'pid'
        pid = getpid();

Compiler: clang-9
Nim Compiler: 1.0.4
Windows 10.

Usage:

when defined(windows):
    {.passC: "-I"  & os.getEnv("VCPKG_ROOT") & "/installed/x64-windows/include"}
    {.passL: "-L"  & os.getEnv("VCPKG_ROOT") & "/installed/x64-windows-static/lib -lzlib -lz"}
import zip/zipfiles

[bubthegreat]

It looks like the package assumes that you have zlib1.dll in your path already. For linux, this is true, but for windows this is only the case if you've installed and configured vscode or something similar already. For a bare install of windows you'll have to download the dll from somewhere (I used vcpkg) and make sure it's added to your path.

It seems more reasonable to include the dll, so, etc files in the nim package and then choose which one to use based on OS, rather than assuming that the OS has it installed.

[matkuki]

I have a different problem:

C:\...\nim_builder_d\libzip_all.c.o:libzip_all.c:(.text+0x117): undefined reference to `zError'
C:\...\nim_builder_d\libzip_all.c.o:libzip_all.c:(.text+0x2dcb): undefined reference to `crc32'
C:\...\nim_builder_d\libzip_all.c.o:libzip_all.c:(.text+0x2e71): undefined reference to `deflateInit2_'
C:\...\nim_builder_d\libzip_all.c.o:libzip_all.c:(.text+0x2f1c): undefined reference to `deflateEnd'
C:\...\nim_builder_d\libzip_all.c.o:libzip_all.c:(.text+0x2f8a): undefined reference to `crc32'
C:\...\nim_builder_d\libzip_all.c.o:libzip_all.c:(.text+0x2fb4): undefined reference to `deflate'
C:\...\nim_builder_d\libzip_all.c.o:libzip_all.c:(.text+0x30bc): undefined reference to `deflateEnd'
C:\...\nim_builder_d\libzip_all.c.o:libzip_all.c:(.text+0x3997): undefined reference to `zError'
C:\...\nim_builder_d\libzip_all.c.o:libzip_all.c:(.text+0x3a4a): undefined reference to `inflateEnd'
C:\...\nim_builder_d\libzip_all.c.o:libzip_all.c:(.text+0x3ba9): undefined reference to `crc32'
C:\...\nim_builder_d\libzip_all.c.o:libzip_all.c:(.text+0x3c9d): undefined reference to `crc32'
C:\...\nim_builder_d\libzip_all.c.o:libzip_all.c:(.text+0x4251): undefined reference to `inflateInit2_'
C:\...\nim_builder_d\libzip_all.c.o:libzip_all.c:(.text+0x453f): undefined reference to `crc32'
C:\...\nim_builder_d\libzip_all.c.o:libzip_all.c:(.text+0x6cfe): undefined reference to `crc32'
C:\...\nim_builder_d\libzip_all.c.o:libzip_all.c:(.text+0x6d69): undefined reference to `inflate'
C:\...\nim_builder_d\libzip_all.c.o:libzip_all.c:(.text+0x6df5): undefined reference to `crc32'

Any ideas what's missing?

[pietroppeter]

I also have the same issue as @matkuki. This is compiling a file with only the line: import zip/zipfiles on windows 10, nim 1.4, gcc 8.1.0 (also tried to nimble install zip@#head).

edit: the fix in #33 works for me on windows. Unfortunately that is a closed issue and less visible.

I think all info is there for a new PR that incorporates #38 and also fixes this issue with windows. It probably could be good to add CI (zip does not seem to be in important packages). I will try to come up with a PR. Incidentally I also noticed that some of the readme examples are broken (some discard are missing, I guess they were taken from test files removing check and require...), I could probably fix that too.

[Toma400]

Hey @pietroppeter, do you think you could maybe create a PR that you mentioned here? It seems like this issue will haunt zip library for eternity, and if it's possible to fix this, I'd absolutely appreciate anything that can help with it.

[pietroppeter]

Hi @Toma400, sorry but I do not have a windows machine anymore so I do not think I would be able to test a PR (honestly also in this period I really do not have bandwidth to contribute here). IIRC there was already some working code somewhere and the effort was just to package into it a PR and test it locally before sending for approval