Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIGABORT while parsing an invalid config #1064

Open
nikitabobko opened this issue Feb 4, 2025 · 1 comment
Open

SIGABORT while parsing an invalid config #1064

nikitabobko opened this issue Feb 4, 2025 · 1 comment
Labels
bug Something isn't working as expected priority-minor

Comments

@nikitabobko
Copy link
Owner

nikitabobko commented Feb 4, 2025 •
edited
Loading 

[[[on-window-detected]]
if.app-id = 'com.apple.findmy'
run = 'layout floating'

[on-window-detected]]
if.app-id = 'com.openai.chat'
run = 'layout floating'

Fails with:

Assertion failed: (is_bare_key_character(*cp) || is_string_delimiter(*cp)), function parse_key, file toml.hpp, line 14038.
fish: Job 1, './.debug/AeroSpaceApp --config-…' terminated by signal SIGABRT (Abort)

The problem should be further investigated and reported to https://github.com/LebJe/TOMLKit and/or https://github.com/marzer/tomlplusplus/

Originally reported at: #1061
@nikitabobko nikitabobko added bug Something isn't working as expected priority-minor labels Feb 4, 2025
fullmetalsheep added a commit to fullmetalsheep/AeroSpace that referenced this issue Feb 24, 2025
@fullmetalsheep
ISSUE-nikitabobko#1064 Prevent crash caused by TOMLKit Parsing error
f9b82da 
- Prevents TOMLKit table header parsing error from crashing AeroSpace by
doing a pre-check for invalid table headers.

- Additionally throws a helpful user error showing the line number +
content of the invalid config line
fullmetalsheep added a commit to fullmetalsheep/AeroSpace that referenced this issue Feb 24, 2025
@fullmetalsheep
ISSUE-nikitabobko#1064 Prevent crash caused by TOMLKit Parsing error
a3d2378 
- Prevents TOMLKit table header parsing error from crashing AeroSpace by
doing a pre-check for invalid table headers.

- Additionally throws a helpful user error showing the line number +
content of the invalid config line
@fullmetalsheep fullmetalsheep mentioned this issue Feb 24, 2025
Open
@fullmetalsheep
Copy link
Contributor

fullmetalsheep commented Feb 24, 2025 •
edited
Loading

Hi,

I've debugged this for a bit and reported my findings against the TOMLKit Repo

Additionally made a PR which prevents this from crashing AeroSpace here: #1134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected priority-minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikitabobko @fullmetalsheep