Merge pull request #504 from ktakahashimtb/ktakahashimtb/close-handle

0-wiz-0 · web-flow · commit 3cd08fb38bbc · 2025-09-17T23:45:44.000+02:00
Close handle from FindFirstFile call
diff --git a/lib/zip_source_file_win32_named.c b/lib/zip_source_file_win32_named.c
@@ -213,9 +213,11 @@ _zip_win32_named_op_stat(zip_source_file_context_t *ctx, zip_source_file_stat_t
             if (file_attributes.dwFileAttributes & FILE_ATTRIBUTE_REPARSE_POINT) {
                 WIN32_FIND_DATA find_data;
                 /* Deduplication on Windows replaces files with reparse points;
-		 * accept them as regular files. */
-                if (file_ops->find_first_file(ctx->fname, &find_data) != INVALID_HANDLE_VALUE) {
+                 * accept them as regular files. */
+                HANDLE find_handle = file_ops->find_first_file(ctx->fname, &find_data);
+                if (find_handle != INVALID_HANDLE_VALUE) {
                     st->regular_file = (find_data.dwReserved0 == IO_REPARSE_TAG_DEDUP);
+                    FindClose(find_handle);
                 }
             }
             else {

Original file line number	Diff line number	Diff line change
`@@ -213,9 +213,11 @@ _zip_win32_named_op_stat(zip_source_file_context_t *ctx, zip_source_file_stat_t`
`213`	`213`	`if (file_attributes.dwFileAttributes & FILE_ATTRIBUTE_REPARSE_POINT) {`
`214`	`214`	`WIN32_FIND_DATA find_data;`
`215`	`215`	`/* Deduplication on Windows replaces files with reparse points;`
`216`		`- * accept them as regular files. */`
`217`		`- if (file_ops->find_first_file(ctx->fname, &find_data) != INVALID_HANDLE_VALUE) {`
	`216`	`+ * accept them as regular files. */`
	`217`	`+ HANDLE find_handle = file_ops->find_first_file(ctx->fname, &find_data);`
	`218`	`+ if (find_handle != INVALID_HANDLE_VALUE) {`
`218`	`219`	`st->regular_file = (find_data.dwReserved0 == IO_REPARSE_TAG_DEDUP);`
	`220`	`+ FindClose(find_handle);`
`219`	`221`	`}`
`220`	`222`	`}`
`221`	`223`	`else {`