-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple file paths for key caching #45
Comments
At the moment, you can either;
Multiple files like you described in your example will not work that way. But this can be implemented. |
Hey @lewis785, I'm doing my own tests on my end. What do you think about the following approaches: Comma-separated:node-cache: &node-cache
id: node
key: "v1-cache-{{ id }}-{{ runner.os }}-{{ checksum 'package-lock.json,src/example-1/package-lock.json,src/example-2/package-lock.json' }}" Glob-pattern:node-cache: &node-cache
id: node
key: "v1-cache-{{ id }}-{{ runner.os }}-{{ checksum '**/package-lock.json' }}" P.S.: This may be miss the main Key-based:node-cache: &node-cache
id: node
key: "v1-cache-{{ id }}-{{ runner.os }}-{{ checksum }}" # if no data given, checksum key below will be used:
checksum: # list of files to get cheksums
- package-lock.json
- **/package-lock.json # and glob pattern! or maybe full list of single files... It seems Any ideas? |
I think the key based approach is the best, it would provide people plenty of flexability. Additionally it keeps it consistent with how multiple paths are defined. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Not stale. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Not stale |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
not stale |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Not stale |
Is it possible to use multiple files for the checksum? I am trying to add caching to a repository that has multiple sub packages and would like the cache to update if any of the package-lock files were change.
Example:
The cache seems to still work but says that it is unable to find the files.
Result:
The text was updated successfully, but these errors were encountered: