Stored setpoint incorrectly updated when controller goes offline

[iainlane]

I just noticed that my system was heating even when no zones were asking for it. I'm using a Nest, and Better Thermostat. zoned-heating is set to control the underlying TRV entities.

I'd previously instrumented zoned-heating with debug logging and turns on debug logging for the Nest integration and zoned-heating. I see these logs:

2024-01-29 09:30:16.878 DEBUG (MainThread) [google_nest_sdm.event] EventMessage raw_data={'eventId': 'b0820f0a-0dfb-4f27-95e2-03833004b514', 'timestamp': '2024-01-29T09:30:09.198Z', 'resourceUpdate': {'name': 'enterprises/mynest', 'traits': {'sdm.devices.traits.Connectivity': {'status': 'OFFLINE'}}}, 'userId': 'myUserId', 'resourceGroup': ['enterprises/mynest']}
2024-01-29 09:30:16.878 DEBUG (MainThread) [google_nest_sdm.device] Processing update b0820f0a-0dfb-4f27-95e2-03833004b514 @ 2024-01-29 09:30:09.198000+00:00
2024-01-29 09:30:16.878 DEBUG (MainThread) [google_nest_sdm.device] Trait update {'sdm.devices.traits.Connectivity': {'status': 'OFFLINE'}, 'name': 'enterprises/mynest'}
2024-01-29 09:30:16.885 DEBUG (MainThread) [custom_components.better_thermostat.utils.watcher] better_thermostat Dining Room: sensor.thermostat_temperature is unavailable. with state unavailable
2024-01-29 09:30:16.886 DEBUG (MainThread) [custom_components.better_thermostat.utils.watcher] better_thermostat Dining Room: sensor.thermostat_temperature is unavailable. with state unavailable
2024-01-29 09:30:16.886 DEBUG (MainThread) [custom_components.zoned_heating.switch] Storing controller setpoint=None
2024-01-29 09:30:21.141 DEBUG (MainThread) [google_nest_sdm.event] EventMessage raw_data={'eventId': '6aecfa88-1a42-4c9b-9645-a3c94d4dc5f2', 'timestamp': '2024-01-29T09:30:17.333Z', 'resourceUpdate': {'name': 'enterprises/mynest', 'traits': {'sdm.devices.traits.Connectivity': {'status': 'ONLINE'}}}, 'userId': 'myUserId', 'resourceGroup': ['enterprises/mynest']}
2024-01-29 09:30:21.141 DEBUG (MainThread) [google_nest_sdm.device] Processing update 6aecfa88-1a42-4c9b-9645-a3c94d4dc5f2 @ 2024-01-29 09:30:17.333000+00:00
2024-01-29 09:30:21.141 DEBUG (MainThread) [google_nest_sdm.device] Trait update {'sdm.devices.traits.Connectivity': {'status': 'ONLINE'}, 'name': 'enterprises/mynest'}
2024-01-29 09:30:21.146 DEBUG (MainThread) [custom_components.zoned_heating.switch] Storing controller setpoint=18.0

So: the Nest goes OFFLINE for 5 seconds, and we clear the stored setpoint. When it comes back online we restore it to what the Nest is set to.

I'd like the stored setpoint to have been remembered in this case. What should we do - ignore the controller becoming unavailable?

[nielsfaber]

Looks like a good improvement. I never considered this scenario during implementation/testing.

[nielsfaber]

Can you open a PR for merging your code changes?