From 468afb7ad2de7efb760e75a073f039747d5792c5 Mon Sep 17 00:00:00 2001 From: "Borie, Niels" Date: Wed, 6 Mar 2024 10:25:38 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A8=20Add=20explicitly=20REGISTRY=5FUR?= =?UTF-8?q?L=20in=20the=20ci=20goal?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/build_and_publish.yml | 2 +- Makefile | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build_and_publish.yml b/.github/workflows/build_and_publish.yml index f15cb85..3c60f99 100644 --- a/.github/workflows/build_and_publish.yml +++ b/.github/workflows/build_and_publish.yml @@ -35,6 +35,6 @@ jobs: if [ "${{ github.ref }}" != 'refs/heads/main' ] && [ "${{ github.ref }}" != 'refs/heads/develop' ]; then SUPPORTED_PYTHON_VERSIONS="3.9 3.12" fi - make build-and-push-all-images + make build-and-push-all-images REGISTRY_URL=nielsborie - name: 🎉 Image digest run: echo ${{ steps.docker_build.outputs.digest }} diff --git a/Makefile b/Makefile index 60c0f4f..74b5534 100644 --- a/Makefile +++ b/Makefile @@ -51,9 +51,9 @@ build-and-push-all-images: ## Build all machine-learning-environments docker ima @for version in $(SUPPORTED_PYTHON_VERSIONS); do \ for builder in $(ALL_BUILDERS); do \ for layer in $(ALL_LAYERS); do \ - $(MAKE) build-image PYTHON_VERSION=$$version LAYER=$$layer BUILDER=$$builder IMAGE_VERSION=$(IMAGE_VERSION); \ + $(MAKE) build-image REGISTRY_URL=$(REGISTRY_URL) PYTHON_VERSION=$$version LAYER=$$layer BUILDER=$$builder IMAGE_VERSION=$(IMAGE_VERSION); \ if [ "$(BRANCH_NAME)" = "develop" ] || [ "$(BRANCH_NAME)" = "main" ]; then \ - $(MAKE) push-image PYTHON_VERSION=$$version LAYER=$$layer BUILDER=$$builder IMAGE_VERSION=$(IMAGE_VERSION); \ + $(MAKE) push-image REGISTRY_URL=$(REGISTRY_URL) PYTHON_VERSION=$$version LAYER=$$layer BUILDER=$$builder IMAGE_VERSION=$(IMAGE_VERSION); \ fi \ done; \ $(MAKE) clean-images; \