Skip to content

Commit b98482f

Browse files
committed
fix data race linux
1 parent 83ba8b0 commit b98482f

3 files changed

Lines changed: 23 additions & 4 deletions

File tree

‎Dockerfile.test-race‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
# syntax=docker/dockerfile:1
2+
3+
# used to test linux -race local
4+
# docker build --progress plain -t sqlot-test -f Dockerfile.test-race .
5+
6+
FROM golang:1.23.2-alpine AS builder
7+
8+
RUN go version
9+
10+
RUN apk --no-cache add gcc g++
11+
12+
WORKDIR /go/src/demo/
13+
COPY . ./
14+
15+
RUN set -Eeux && go mod tidy && go mod download && go mod verify
16+
17+
ARG GO_TAGS
18+
ARG PROJECT_VERSION
19+
20+
RUN GOOS=linux CGO_ENABLED=1 go test -v -race ./...

‎sqlite/storage_test.go‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ func Test_Sqlite_TotalSizeCap(t *testing.T) {
125125
for j := 0; j < 3; j++ {
126126
root := sqlog.NewChunk(100)
127127
chunk := root
128-
for i := 0; i < 1000; i++ {
128+
for i := 0; i < 1001; i++ {
129129
chunk, _ = chunk.Put(&sqlog.Entry{
130130
Time: time.Now(), //.Add(time.Duration(-1) * time.Second),
131131
Level: 0,
@@ -152,7 +152,6 @@ func Test_Sqlite_TotalSizeCap(t *testing.T) {
152152
assert.Equal(t, len(storage.liveDbs), 1)
153153

154154
assert.NoFileExists(t, firstDb.filePath)
155-
assert.FileExists(t, storage.dbs[0].filePath)
156155
assert.FileExists(t, storage.dbs[1].filePath)
157156

158157
}

‎sqlite/storage_test_driver_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,12 @@ func (d *mockDriver) Open(dsn string) (driver.Conn, error) {
3030
}
3131

3232
// simulate sqlite wal
33-
file, err := os.OpenFile(url.Opaque, os.O_CREATE|os.O_APPEND, 0755)
33+
file, err := os.OpenFile(url.Opaque, os.O_CREATE|os.O_APPEND|os.O_RDWR, 0755)
3434
if err != nil {
3535
return nil, err
3636
}
3737

38-
wal, err := os.OpenFile(url.Opaque+"-wal", os.O_CREATE, 0755)
38+
wal, err := os.OpenFile(url.Opaque+"-wal", os.O_CREATE|os.O_RDWR, 0755)
3939
if err != nil {
4040
return nil, err
4141
}

0 commit comments

Comments
 (0)