Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

landmark structure of layout html #42

Open
IK-Ngoo opened this issue Aug 19, 2024 · 0 comments
Open

landmark structure of layout html #42

IK-Ngoo opened this issue Aug 19, 2024 · 0 comments
Assignees
Labels

Comments

@IK-Ngoo
Copy link
Contributor

IK-Ngoo commented Aug 19, 2024

Root cause

layout html for running example didn't support proper landmark structure:

將造成:

  • 瀏覽者不易掌握頁面地標結構。
  • 使用 NVDA 測試,無法使用快捷鍵迅速在地標之間移動。

References

html

<main id="main">{{ content }}</main>

<div class="one-col">
<header class="site-header">
<a href="{{ "/" | absolute_url}}" class="flex items-center">
<div class="bg-layer1 w2 mr3" style="aspect-ratio: 1;"><!-- logo --></div>
<h1>{{ page.title }}</h1>
</a>
<nav aria-label="主要" class="flex gap4 mt4">
<a href="#">首頁</a>
<a href="#">關於我們</a>
</nav>
</header>
<main class="site-main" id="main">

<div class="one-column bg-layer1">
<footer class="site-footer f6 flex items-center gap4">
<div class="plain w2 mr3" style="aspect-ratio: 1;"><!-- logo --></div>
<div class="mw5">
<a href="/accessibility-statement">親和力宣告</a>
</div>
</footer>
</div>

Possible solutions

  1. 暫時處理方式: demo page, landmark 元件先使用不同 layout
  2. 後續處理方式:應該設計出一套可以兼容不同展示情境需求的 layout
@IK-Ngoo IK-Ngoo added 缺陷 bug Something isn't working 親和力 accessibility labels Aug 19, 2024
@IK-Ngoo IK-Ngoo self-assigned this Aug 19, 2024
@IK-Ngoo IK-Ngoo changed the title landmark structure of example-html landmark structure of layout html Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant