Fixed paths with spaces in them

Author: nickrallison

src/managers/scriptManager.ts

@@ -28,11 +28,14 @@ export class ScriptManager {
             // Replace any unescaped quotes with escaped quotes
             return `"${arg.replace(/"/g, '\\"')}"`;
         });
-
+    
+        // Quote the script path to handle spaces
+        const quotedScriptPath = `"${scriptPath}"`;
+    
         let cmd = scriptConfig.interpreter
-            ? `${scriptConfig.interpreter} ${scriptPath} ${escapedArgs.join(' ')}`
-            : `${scriptPath} ${escapedArgs.join(' ')}`;
-
+            ? `"${scriptConfig.interpreter}" ${quotedScriptPath} ${escapedArgs.join(' ')}`
+            : `${quotedScriptPath} ${escapedArgs.join(' ')}`;
+    
         // check if command is executable
         this.plugin.log(`Running script: ${scriptPath}, with interpreter: ${interpreter}`, 'verbose');
         if (!this.isRunnable(interpreter, scriptPath)) {
@@ -45,11 +48,11 @@ export class ScriptManager {
             }
             return;
         }
-
+    
         if (this.settings.verbosity === 'verbose') {
             this.plugin.log(`Executing command: ${cmd}`, 'verbose');
         }
-
+    
         let scriptStartTime = Date.now();
         exec(cmd, (error, stdout, stderr) => {
             // Handle output based on scriptConfig.output
@@ -65,13 +68,13 @@ export class ScriptManager {
                     }
                 }
             }
-
+    
             // Handle errors
             if (error) {
                 new Notice('Error executing script.', 5000);
                 this.plugin.log('Error executing script:', "silent");
             }
-
+    
             const scriptEndTime = Date.now();
             const scriptDuration = scriptEndTime - scriptStartTime;
             new Notice(`Script executed successfully (took ${scriptDuration} ms), output: ${stdout}`, 5000);

src/settings/scriptSettingsTab.ts

@@ -15,7 +15,7 @@ export class ScriptSettingsTab extends PluginSettingTab {
 
     // Method to list scripts in the directory
     async listScripts(): Promise<string[]> {
-        const scriptsFolder = path.join(this.plugin.app.vault.configDir, this.plugin.settings.scriptsFolder);
+        const scriptsFolder = path.join(this.plugin.settings.scriptsFolder);
         // if the directory is an absolute path, print an error and return an empty array
         if (path.isAbsolute(this.plugin.settings.scriptsFolder)) {
             this.plugin.log(`Scripts directory path is absolute: ${this.plugin.settings.scriptsFolder}, change to local path`, 'silent');
@@ -26,6 +26,8 @@ export class ScriptSettingsTab extends PluginSettingTab {
             const items = await this.listFilesRecursive(scriptsFolder);
             return items;
         } catch (error) {
+            this.plugin.log(`Scripts directory: ${scriptsFolder}`, 'verbose');
+
             this.plugin.log(`Error reading directory: ${error}`, 'silent');
             return [];
         }
@@ -34,7 +36,8 @@ export class ScriptSettingsTab extends PluginSettingTab {
     async listFilesRecursive(dir: string): Promise<string[]> {
         try {
             let results: string[] = [];
-            const items = await this.plugin.app.vault.adapter.list(dir);
+            let dir_spaces_escaped = dir.replace(" ", "\ ");
+            const items = await this.plugin.app.vault.adapter.list(dir_spaces_escaped);
             const scriptsFolder = path.join(this.plugin.app.vault.configDir, this.plugin.settings.scriptsFolder);
 
             // Add all files from current directory