Merge pull request #2498 from nickel-lang/closurize-overrides

Recursively closurize the overrides

Author: jneem

cli/tests/snapshot/inputs/customize-mode/closurization.ncl

@@ -0,0 +1,12 @@
+# capture = 'stderr'
+# command = ['export']
+# extra_args = [
+#  '--',
+#  'inputs.user="me"',
+# ]
+{
+  inputs = {
+    user | String | default = "defaultuser",
+  },
+  result = inputs.user,
+}

cli/tests/snapshot/snapshots/snapshot__export_stderr_closurization.ncl.snap

@@ -0,0 +1,5 @@
+---
+source: cli/tests/snapshot/main.rs
+expression: err
+---
+

core/src/term/make/builder.rs

@@ -230,10 +230,12 @@ where
     let fst = it.next().unwrap();
 
     let content = it.rev().fold(content, |acc, id| {
-        record::Field::from(NickelValue::record_posless(RecordData {
-            fields: [(LocIdent::from(id), acc)].into(),
-            ..Default::default()
-        }))
+        record::Field::from(NickelValue::term_posless(Term::Closurize(
+            NickelValue::record_posless(RecordData {
+                fields: [(LocIdent::from(id), acc)].into(),
+                ..Default::default()
+            }),
+        )))
     });
 
     (fst.into(), content)
@@ -349,9 +351,8 @@ impl Record {
     /// # Closurization
     ///
     /// [Self::build] is intended to provide a ready-to-use value, so the built record is wrapped
-    /// into a [crate::term::Term::Closurize] operation. Otherwise, since records are assumed to be
-    /// closurized during evaluation, using a bare record at runtime would either panic or
-    /// introduce subtle bugs.
+    /// into a [crate::term::Term::Closurize] operation, as are any sub-records implicitly created
+    /// by field paths. However, field values are not automatically closurized.
     pub fn build(self) -> NickelValue {
         let elaborated = self
             .fields