Skip to content

Conversation

bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Sep 17, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Update run_system_tests.yml to use ni/python-actions/setup-python and ni/python-actions/setup-poetry.

Why should this Pull Request be merged?

Allow ni/python-actions to specify the default Python and Poetry versions used to run Tox.

What testing has been done?

PR build

Copy link
Contributor

github-actions bot commented Sep 17, 2025

Test Results

    38 files  ±0      38 suites  ±0   1h 3m 5s ⏱️ +54s
 2 835 tests ±0   2 243 ✅ ±0    592 💤 ±0  0 ❌ ±0 
48 968 runs  ±0  40 280 ✅ ±0  8 688 💤 ±0  0 ❌ ±0 

Results for commit c6bc759. ± Comparison against base commit d629c76.

♻️ This comment has been updated with latest results.

@bkeryan bkeryan closed this Sep 17, 2025
@bkeryan bkeryan reopened this Sep 20, 2025
@bkeryan
Copy link
Collaborator Author

bkeryan commented Sep 20, 2025

FYI, we will also want this ni/python-actions change: ni/python-actions#26

This changes the Poetry install directory and includes this directory in the cache key. The old Poetry install directory was in $HOME, and this is a different directory between GitHub-hosted and self-hosted runners.

Copy link
Collaborator

@zhindes zhindes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bkeryan bkeryan merged commit cd5cbac into master Sep 30, 2025
27 checks passed
@bkeryan bkeryan deleted the users/bkeryan/setup-poetry branch September 30, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants