Remove deprecated properties, methods and data types in NIMS v2.x.x

[jayaseelan-james]

User Story

Several properties, methods, and data types have been deprecated in NIMS across various versions of our 1.x.x release. Now that we've moved to 2.x.x, we should consider removing the deprecated properties, APIs and data types.

Deprecated properties and methods:

• _internal\discovery_client.py
• _internal\service_manager.py
  • discovery_client
  • port
  • server
• discovery\_client.py
  • registration_id
  • stub
  • register_measurement_service
• measurement\service.py
  • configuration_parameter_list
  • grpc_service
  • measure_function
  • output_parameter_list
• session_management\__init__.py

Deprecated data types:

• Pin (here and here)
• Pin1DArray (here and here)

AB#2783781

[bkeryan]

@dixonjoel How much of this was removed in 3.0.0?

[dixonjoel]

@dixonjoel How much of this was removed in 3.0.0?

@bkeryan Nearly all still around. I'm happy to remove them, but do we have to make another breaking release? I'd be very surprised if anyone missed them.

[bkeryan]

S C:\dev\measurement-plugin-python\packages\service> rg -i depreca .\ni_measurement_plugin_sdk_service\
.\ni_measurement_plugin_sdk_service\measurement\service.py
24:from deprecation import deprecated
222:                "The 'version' constructor parameter is deprecated. Specify the version using the 'version' field in the .serviceconfig file instead.",
223:                DeprecationWarning,
298:    @deprecated(
299:        deprecated_in="1.3.0-dev0",
307:    @deprecated(
308:        deprecated_in="1.3.0-dev0",
316:    @deprecated(
317:        deprecated_in="1.3.0-dev0",
325:    @deprecated(
326:        deprecated_in="1.3.0-dev0",
399:                is DataType.IOResource or DataType.Pin (deprecated).
419:                "DataType.Pin is deprecated. Use DataType.IOResource instead.", DeprecationWarning
423:                "DataType.PinArray1D is deprecated. Use DataType.IOResourceArray1D instead.",
424:                DeprecationWarning,
486:                "DataType.Pin is deprecated. Use DataType.IOResource instead.", DeprecationWarning
490:                "DataType.PinArray1D is deprecated. Use DataType.IOResourceArray1D instead.",
491:                DeprecationWarning,

.\ni_measurement_plugin_sdk_service\grpc\channelpool.py
7:compatibility with existing applications and will be deprecated in a future

.\ni_measurement_plugin_sdk_service\session_management\__init__.py
7:provides compatibility with existing applications and will be deprecated in a

.\ni_measurement_plugin_sdk_service\discovery\__init__.py
7:compatibility with existing applications and will be deprecated in a future

.\ni_measurement_plugin_sdk_service\grpc\loggers.py
7:compatibility with existing applications and will be deprecated in a future

.\ni_measurement_plugin_sdk_service\grpc\__init__.py
7:compatibility with existing applications and will be deprecated in a future

.\ni_measurement_plugin_sdk_service\pin_map\__init__.py
7:compatibility with existing applications and will be deprecated in a future

.\ni_measurement_plugin_sdk_service\_internal\discovery_client.py
5:from deprecation import DeprecatedWarning
11:    DeprecatedWarning(
13:        deprecated_in="1.3.0",

.\ni_measurement_plugin_sdk_service\_internal\service_manager.py
7:from deprecation import deprecated
51:    @deprecated(
52:        deprecated_in="1.3.0-dev0",
60:    @deprecated(
61:        deprecated_in="1.3.0-dev0",
69:    @deprecated(
70:        deprecated_in="1.3.0-dev0",

• .\ni_measurement_plugin_sdk_service\measurement\service.py: these are public APIs, so removing them in a minor/update bump would break assumptions that you can upgrade from 3.0.0 to 3.0.x or 3.x.
• init.py files: these are just comments
• .\ni_measurement_plugin_sdk_service_internal\discovery_client.py: this is internal, so removing it in a minor/update bump would not technically break the semver spec. There is still some "measurement template" code in ASW that uses it, but that code seems to include a fork of this package.
• .\ni_measurement_plugin_sdk_service_internal\service_manager.py: this is internal too, and I can't find any code that uses it.