github: Remove unit_tests_succeeded step #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bkeryan I think this is better and I see you already updated the required checks. The only (probably not worth it) benefit of having 'Unit tests succeeded' is that would get reported on the PR checks faster and wouldn't have to wait for the system Test Results which tend to take a long time. But I'm fine with this. |
dixonjoel
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Remove
unit_tests_succeededstep.Why should this Pull Request be merged?
https://github.com/EnricoMi/publish-unit-test-result-action already summarizes test results in the "Test Results" check.
What testing has been done?
PR build