Skip to content

Conversation

dixonjoel
Copy link
Collaborator

What does this Pull Request accomplish?

Re-use the analyze-project action from python-actions repo.

Why should this Pull Request be merged?

Standard analysis of a Python package.

What testing has been done?

PR

@dixonjoel
Copy link
Collaborator Author

@bkeryan I think we could update check_examples to use analyze-project. It would be trickier since we enumerate them and check them, but I don't see any major hurdles. Do you think that's something we want to do?

@bkeryan
Copy link
Collaborator

bkeryan commented Oct 6, 2025

@bkeryan I think we could update check_examples to use analyze-project. It would be trickier since we enumerate them and check them, but I don't see any major hurdles. Do you think that's something we want to do?

Sure, you can use a matrix like in ni-apis-python.

Copy link
Contributor

github-actions bot commented Oct 6, 2025

Test Results

    52 files  ±0      52 suites  ±0   1h 17m 5s ⏱️ + 2m 57s
   689 tests ±0     689 ✅ ±0      0 💤 ±0  0 ❌ ±0 
20 700 runs  ±0  19 644 ✅ ±0  1 056 💤 ±0  0 ❌ ±0 

Results for commit 0559607. ± Comparison against base commit 9192eab.

♻️ This comment has been updated with latest results.

@dixonjoel dixonjoel marked this pull request as ready for review October 7, 2025 20:06
@dixonjoel dixonjoel requested a review from bkeryan October 7, 2025 21:20
@dixonjoel
Copy link
Collaborator Author

@bkeryan FYI, adding 'checks_succeeded' and 'unit_tests_succeeded' as summary steps to reduce the required checks.

@dixonjoel dixonjoel merged commit 9d58617 into main Oct 9, 2025
30 checks passed
@dixonjoel dixonjoel deleted the users/jdixon/reuse-analyze-project-action branch October 9, 2025 17:18
@bkeryan
Copy link
Collaborator

bkeryan commented Oct 9, 2025

@bkeryan FYI, adding 'checks_succeeded' and 'unit_tests_succeeded' as summary steps to reduce the required checks.

For tests, use "Test Results", provided by https://github.com/EnricoMi/publish-unit-test-result-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants