Replies: 5 comments 2 replies
-
Sounds good - would you want to do it as a self contained PR or will you roll it in to some other refactoring? |
Beta Was this translation helpful? Give feedback.
-
After my last run, I'm thinking it would be best to keep the PRs to a single refactoring effort, instead of bundling 3 or 4 like I did with my last one. So I say we just go for it with this one. |
Beta Was this translation helpful? Give feedback.
-
I did some coding on this and it does work and it is cleaner. But considering both of these decorations are for showing some loading process is happening, I can't help but think these decorations and their respective buttons should be replaced with an XControl or QControl. In summary, if we want a quick improvement, using the UID lookup is good. In the long term, we need to explore a more modular approach to how these controls are handled. |
Beta Was this translation helpful? Give feedback.
-
NOTE: I incorporated this idea with the code I am submitting for #232 |
Beta Was this translation helpful? Give feedback.
-
Apparently the UID values change when built into a PPL. I will make an issue to get this corrected by going back to the old way of getting the references. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
As part of the initialization, two references are found to decorations based on tab pages. @dnattinger recently put this nugget in the LabVIEW Discord:
"I typically create the free label, programmatically figure out its UID, then use [LabVIEW 20xx]\vi.lib\VIServer\UID to GObject Reference.vi wherever I need to programmatically modify the label. The UID of a GObject never changes."
We could do something similar for these two decorations we currently do a more fragile lookup for.
Beta Was this translation helpful? Give feedback.
All reactions