Ability to click the Cancel button by pressing the ESC key

[RobustoSystems]

The ability to click the Cancel button by pressing the ESC (Escape) key would be useful.

This issue is somewhat related (but independent to) Issue #100.

This could be implemented via the Key Navigation properties of the Cancel button, as seen below.

[crossrulz]

After 2 minutes of digging, it will not be so simple as the original post assumes. The Escape key is handled by a Key Down? event that involves many layers of case structures based on settings I have no clue what they are. If you are looking for a quick issue, this is not currently it.

With all that said, we need to consider carefully the situations we expect the ESC key to close the editor. It currently unselects items and tools.

[RobustoSystems]

Hi Tim,

Thanks for the detailed information. "If you are looking for a quick issue, this is not currently it." - Haha, yes, I was hoping that this will be a very quick and easy feature to implement. Alas, it wasn't to be.

"With all that said, we need to consider carefully the situations we expect the ESC key to close the editor. It currently unselects items and tools." - Fully agree. Please excuse my ignorance in the original post - I was unaware that ESC is handled already, and so thought it was "free" to use for additional functionality.

[crossrulz]

Please excuse my ignorance in the original post

If it makes you feel better, I tried doing the key navigation and wondered why it wasn't working. That's when I started digging.

[svelderrainruiz]

I am moving this to a discussion while this gathers more input.

[crossrulz]

Once Pull Request #191 (adding a confirm cancel dialog) gets merged, I think we can give this idea another look.

[crossrulz]

Playing with this again after the Steerco meeting, it does look like the simple key binding will work. The KeyDown? event will need to be completed before the key binding toggle will be able to be performed. As long as the KeyDown? discards the event if it actually did something, there will not be a conflict. The key binding will just become a default.

With the addition of the cancel confirmation dialog in PR #191 (once it gets approved and merged), I am no longer worried about an accidental cancellation.

[crossrulz]

Completed with #230 merged into develop