You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[ ] bug report => check the FAQ and search github for a similar issue or PR before submitting
[ ] support request => check the FAQ and search github for a similar issue before submitting
[X] feature request
Current behavior
setTranslation with merge set, really does and extend (Object.assign) under the covers. A True merge would be more useful for those building applications where we need to override translations values from a base translation file.
Expected/desired behavior
setTranslation with merge set should perform a proper merge (like lodash merge)
Reproduction of the problem
If the current behavior is a bug or you can illustrate your feature request better with an example, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:btpW3l0jr5beJVjohy1Q).
What is the expected behavior?
What is the motivation / use case for changing the behavior?
Ability to override nested translations
Please tell us about your environment:
ng2-translate version: x.x.x
Angular version: 2.0.0-rc.X
Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
Language: [all | TypeScript X.X | ES6/7 | ES5]
The text was updated successfully, but these errors were encountered:
I'm submitting a ... (check one with "x")
Current behavior
setTranslation with merge set, really does and extend (Object.assign) under the covers. A True merge would be more useful for those building applications where we need to override translations values from a base translation file.
Expected/desired behavior
setTranslation with merge set should perform a proper merge (like lodash merge)
Reproduction of the problem
If the current behavior is a bug or you can illustrate your feature request better with an example, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:btpW3l0jr5beJVjohy1Q).
What is the expected behavior?
What is the motivation / use case for changing the behavior?
Ability to override nested translations
Please tell us about your environment:
ng2-translate version: x.x.x
Angular version: 2.0.0-rc.X
Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
Language: [all | TypeScript X.X | ES6/7 | ES5]
The text was updated successfully, but these errors were encountered: