You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The library utilizes EventEmitter to emit changes to the selected language.
Expected behavior
The library should rely on a Subject instead, given that these are the most adequate to the use case.
What is the motivation / use case for changing the behavior?
The EventEmitter is made to be utilized with components and directives, as per original angular team instruction.
Furthermore, with the start of moving from @Output/ @Input decorators to signals, output/ input respectively, the usage of the EventEmitter seems inadequate and possible to causes issues due to lack of support in the future.
How do you think we should implement this?
Migrate the onLangChange, onDefaultLangChange and the onTranslationChange from an EventEmitterto a Subject.
I'm ok with forking the repo and doing the changes myself, however, I would like confirmation that is ok before putting work into it.
The text was updated successfully, but these errors were encountered:
Current behavior
The library utilizes EventEmitter to emit changes to the selected language.
Expected behavior
The library should rely on a
Subject
instead, given that these are the most adequate to the use case.What is the motivation / use case for changing the behavior?
The
EventEmitter
is made to be utilized with components and directives, as per original angular team instruction.Furthermore, with the start of moving from
@Output
/@Input
decorators to signals,output
/input
respectively, the usage of theEventEmitter
seems inadequate and possible to causes issues due to lack of support in the future.How do you think we should implement this?
Migrate the
onLangChange
,onDefaultLangChange
and theonTranslationChange
from anEventEmitter
to aSubject
.I'm ok with forking the repo and doing the changes myself, however, I would like confirmation that is ok before putting work into it.
The text was updated successfully, but these errors were encountered: