fix several LGTM warnings

Author: razvancrainea

cmds.h

@@ -19,6 +19,9 @@
  *
  */
 
+#ifndef _CORE_CMDS_H_
+#define _CORE_CMDS_H_
+
 #include "parser/msg_parser.h"
 #include "route_struct.h"
 #include "async.h"
@@ -78,3 +81,5 @@ int check_acmd_call_params(acmd_export_t *acmd, action_elem_t *elems, int no_par
 cmd_export_t* find_core_cmd_export_t(char* name, int flags);
 cmd_export_t* find_mod_cmd_export_t(char* name, int flags);
 acmd_export_t* find_mod_acmd_export_t(char* name);
+
+#endif /* _CORE_CMDS_H_ */

core_stats.c

@@ -184,7 +184,7 @@ static unsigned long get_pkg_fragments( void*proc_id)
 
 int init_pkg_stats(int procs_no)
 {
-	unsigned short n;
+	int n;
 	str n_str;
 	char *name;
 	str sname;

io_wait.h

@@ -336,7 +336,7 @@ static inline int kq_ev_change(io_wait_h* h, int fd, int filter, int flag,
  * functions (it avoids functions calls, the overhead being only an extra
  *  switch())
 */
-inline static int io_watch_add(	io_wait_h* h, /* lgtm [cpp/use-of-goto] */
+inline static int io_watch_add(	io_wait_h* h, // lgtm [cpp/use-of-goto]
 								int fd,
 								fd_type type,
 								void* data,

lib/csv.c

@@ -216,7 +216,6 @@ csv_record *__parse_csv_record(const str *_in, enum csv_flags parse_flags,
 
 void free_csv_record(csv_record *record)
 {
-	osips_free_t free_f;
 	enum csv_flags flags_holder;
 	struct str_list *prev;
 

main.c

@@ -261,8 +261,8 @@ char* working_dir = 0;
 char* chroot_dir = 0;
 char* user=0;
 char* group=0;
-int uid = 0;
-int gid = 0;
+int user_id = 0;
+int group_id = 0;
 
 /* more config stuff */
 int disable_core_dump=0; /* by default enabled */
@@ -273,7 +273,7 @@ int mcast_loopback = 0;
 int mcast_ttl = -1; /* if -1, don't touch it, use the default (usually 1) */
 #endif /* USE_MCAST */
 
-int tos = IPTOS_LOWDELAY;
+int tos = IPTOS_LOWDELAY; // lgtm [cpp/short-global-name]
 
 struct socket_info* bind_address=0; /* pointer to the crt. proc.
 									 listening address*/
@@ -984,13 +984,13 @@ int main(int argc, char** argv)
 
 	/* get uid/gid */
 	if (user){
-		if (user2uid(&uid, &gid, user)<0){
+		if (user2uid(&user_id, &group_id, user)<0){
 			LM_ERR("bad user name/uid number: -u %s\n", user);
 			goto error00;
 		}
 	}
 	if (group){
-		if (group2gid(&gid, group)<0){
+		if (group2gid(&group_id, group)<0){
 			LM_ERR("bad group name/gid number: -u %s\n", group);
 			goto error00;
 		}
@@ -1477,7 +1477,7 @@ int main(int argc, char** argv)
 
 	/* all processes should have access to all the sockets (for sending)
 	 * so we open all first*/
-	if (do_suid(uid, gid)==-1)
+	if (do_suid(user_id, group_id)==-1)
 		goto error;
 
 	ret = main_loop();

mem/hp_malloc_stats.c

@@ -177,9 +177,9 @@ void hp_init_shm_statistics(struct hp_block *hpb)
 	shm_rused->flags |= STAT_NO_RESET;
 	shm_frags->flags |= STAT_NO_RESET;
 #endif
-	update_stat(shm_used, hpb->used);
-	update_stat(shm_rused, hpb->real_used);
-	update_stat(shm_frags, hpb->total_fragments);
+	update_stat(shm_used, (int)hpb->used);
+	update_stat(shm_rused, (int)hpb->real_used);
+	update_stat(shm_frags, (int)hpb->total_fragments);
 
 	LM_DBG("initializing atomic shm statistics: "
 	       "[ us: %ld | rus: %ld | frags: %ld ]\n", hpb->used, hpb->real_used, hpb->total_fragments);

mi/mi_trace.c

@@ -206,9 +206,8 @@ static int mi_mods_no=0;
 
 static int is_id_valid(int id)
 {
-	/* FIXME is this valid? */
-	if ( id >= 8 * sizeof( *(((struct mi_cmd *)0)->trace_mask) ) ||
-			id < 0 )
+	/* mask is currehtly char, we might need to expand it to offer more space */
+	if (id < 0 || id >= 8 * sizeof( *(((struct mi_cmd *)0)->trace_mask) ))
 		return 0;
 
 	return 1;

pt_scaling.c

@@ -68,12 +68,12 @@ int create_auto_scaling_profile( char *name,
 		down_cycles_tocheck = 0;
 		down_cycles_delay = 0;
 	}
-	if (max_procs <= min_procs || max_procs==0 || max_procs>=1000) {
+	if (max_procs==0 || max_procs <= min_procs || max_procs>=1000) {
 		LM_ERR("invalid relation or range for MIN/MAX processes [%d,%d]\n",
 			min_procs, max_procs);
 		return -1;
 	}
-	if (up_threshold <= down_threshold || up_threshold==0 ||
+	if (up_threshold==0 || up_threshold <= down_threshold ||
 	up_threshold>100 || down_threshold>100) {
 		LM_ERR("invalid relation or range DOWN/UP thresholds percentages "
 			"[%d,%d]\n", down_threshold, up_threshold);
@@ -361,6 +361,7 @@ void do_workers_auto_scaling(void)
 				do {
 					load += pg->history_map[k];
 					k = k ? (k-1) : (pg->history_size-1) ;
+					i++;
 				} while( k != idx && i <= pg->prof->down_cycles_tocheck );
 				load = (load*procs_no) /
 					(pg->prof->down_cycles_tocheck * (procs_no-1));