Skip to content

Commit 8880b5f

Browse files
committed
Fix missing "\n" log line endings
Credits to Nick Altmann for the hint!
1 parent 1104a21 commit 8880b5f

File tree

7 files changed

+38
-38
lines changed

7 files changed

+38
-38
lines changed

modules/callops/callops.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ static int call_attended_transfer(struct dlg_cell *dlg, struct sip_msg *msg)
498498
init_callid.len, init_callid.s);
499499
}
500500
} else {
501-
LM_ERR("could not find the transfered callid");
501+
LM_ERR("could not find the transfered callid\n");
502502
}
503503

504504
call_dlg_api.store_dlg_value(rpl_dlg, &call_transfer_param, &rpl_leg);

modules/cfgutils/cfgutils.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ mi_response_t *mi_check_hash(const mi_params_t *params,
405405
return init_mi_error(404, MI_SSTR("Functionality disabled"));
406406
} else {
407407
if (MD5File(tmp, hash_file) != 0) {
408-
LM_ERR("could not hash the config file");
408+
LM_ERR("could not hash the config file\n");
409409
return init_mi_error(500, MI_SSTR("Internal error"));
410410
}
411411

modules/mmgeoip/mmgeoip.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ int parse_mem_option( unsigned int type, void *val)
6060
#ifdef GEOIP
6161
return legacy_parse_cache_type((char *)val);
6262
#else
63-
LM_INFO("Parameter only supported for legacy GeoIP, ignoring...");
63+
LM_INFO("Parameter only supported for legacy GeoIP, ignoring...\n");
6464
return 0;
6565
#endif
6666
}

modules/presence_dfks/presence_dfks.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -966,7 +966,7 @@ void mi_feature_notify(int sender, void *_params)
966966
notify_body = build_feature_notify(&params->pres_uri, params->feature_idx,
967967
0, &params->param, &ct_type);
968968
if (notify_body == (str*)-1) {
969-
LM_ERR("Failed to build NOTIFY body");
969+
LM_ERR("Failed to build NOTIFY body\n");
970970
goto end;
971971
}
972972

modules/proto_smpp/smpp.c

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ rw_lock_t *smpp_lock; /* reader-writers lock for reloading the data */
7676
static uint32_t get_payload_from_header(char *payload, smpp_header_t *header)
7777
{
7878
if (!payload || !header) {
79-
LM_ERR("NULL params");
79+
LM_ERR("NULL params\n");
8080
return 0;
8181
}
8282

@@ -92,7 +92,7 @@ static uint32_t get_payload_from_header(char *payload, smpp_header_t *header)
9292
static uint32_t get_payload_from_bind_transceiver_body(char *body, smpp_bind_transceiver_t *transceiver)
9393
{
9494
if (!body || !transceiver) {
95-
LM_ERR("NULL params");
95+
LM_ERR("NULL params\n");
9696
return 0;
9797
}
9898

@@ -111,7 +111,7 @@ static uint32_t get_payload_from_bind_transceiver_body(char *body, smpp_bind_tra
111111
static uint32_t get_payload_from_bind_transceiver_resp_body(char *body, smpp_bind_transceiver_resp_t *transceiver_resp)
112112
{
113113
if (!body || !transceiver_resp) {
114-
LM_ERR("NULL params");
114+
LM_ERR("NULL params\n");
115115
return 0;
116116
}
117117

@@ -124,7 +124,7 @@ static uint32_t get_payload_from_bind_transceiver_resp_body(char *body, smpp_bin
124124
uint32_t get_payload_from_submit_sm_body(char *body, smpp_submit_sm_t *submit_sm)
125125
{
126126
if (!body || !submit_sm) {
127-
LM_ERR("NULL params");
127+
LM_ERR("NULL params\n");
128128
return 0;
129129
}
130130

@@ -154,7 +154,7 @@ uint32_t get_payload_from_submit_sm_body(char *body, smpp_submit_sm_t *submit_sm
154154
uint32_t get_payload_from_deliver_sm_resp_body(char *body, smpp_deliver_sm_resp_t *deliver_sm_resp)
155155
{
156156
if (!body || !deliver_sm_resp) {
157-
LM_ERR("NULL params");
157+
LM_ERR("NULL params\n");
158158
return 0;
159159
}
160160

@@ -165,7 +165,7 @@ uint32_t get_payload_from_deliver_sm_resp_body(char *body, smpp_deliver_sm_resp_
165165
uint32_t get_payload_from_submit_sm_resp_body(char *body, smpp_submit_sm_resp_t *submit_sm_resp)
166166
{
167167
if (!body || !submit_sm_resp) {
168-
LM_ERR("NULL params");
168+
LM_ERR("NULL params\n");
169169
return 0;
170170
}
171171

@@ -176,33 +176,33 @@ uint32_t get_payload_from_submit_sm_resp_body(char *body, smpp_submit_sm_resp_t
176176
static int build_bind_transceiver_request(smpp_bind_transceiver_req_t **preq, smpp_session_t *session)
177177
{
178178
if (!preq || !session) {
179-
LM_ERR("NULL params");
179+
LM_ERR("NULL params\n");
180180
goto err;
181181
}
182182

183183
/* request allocations */
184184
smpp_bind_transceiver_req_t *req = pkg_malloc(sizeof(*req));
185185
*preq = req;
186186
if (!req) {
187-
LM_ERR("malloc error for request");
187+
LM_ERR("malloc error for request\n");
188188
goto err;
189189
}
190190

191191
smpp_header_t *header = pkg_malloc(sizeof(*header));
192192
if (!header) {
193-
LM_ERR("malloc error for header");
193+
LM_ERR("malloc error for header\n");
194194
goto header_err;
195195
}
196196

197197
smpp_bind_transceiver_t *body = pkg_malloc(sizeof(*body));
198198
if (!body) {
199-
LM_ERR("malloc error for body");
199+
LM_ERR("malloc error for body\n");
200200
goto body_err;
201201
}
202202

203203
req->payload.s = pkg_malloc(REQ_MAX_SZ(BIND_RECEIVER));
204204
if (!req->payload.s) {
205-
LM_ERR("malloc error for payload");
205+
LM_ERR("malloc error for payload\n");
206206
goto payload_err;
207207
}
208208

@@ -245,33 +245,33 @@ static int build_bind_resp_request(smpp_bind_transceiver_resp_req_t **preq, uint
245245
uint32_t command_status, uint32_t seq_no, char *system_id)
246246
{
247247
if (!preq) {
248-
LM_ERR("NULL params");
248+
LM_ERR("NULL params\n");
249249
goto err;
250250
}
251251

252252
/* request allocations */
253253
smpp_bind_transceiver_resp_req_t *req = pkg_malloc(sizeof(*req));
254254
*preq = req;
255255
if (!req) {
256-
LM_ERR("malloc error for request");
256+
LM_ERR("malloc error for request\n");
257257
goto err;
258258
}
259259

260260
smpp_header_t *header = pkg_malloc(sizeof(*header));
261261
if (!header) {
262-
LM_ERR("malloc error for header");
262+
LM_ERR("malloc error for header\n");
263263
goto header_err;
264264
}
265265

266266
smpp_bind_transceiver_resp_t *body = pkg_malloc(sizeof(*body));
267267
if (!body) {
268-
LM_ERR("malloc error for body");
268+
LM_ERR("malloc error for body\n");
269269
goto body_err;
270270
}
271271

272272
req->payload.s = pkg_malloc(REQ_MAX_SZ(BIND_TRANSCEIVER_RESP));
273273
if (!req->payload.s) {
274-
LM_ERR("malloc error for payload");
274+
LM_ERR("malloc error for payload\n");
275275
goto payload_err;
276276
}
277277

@@ -307,27 +307,27 @@ static int build_bind_resp_request(smpp_bind_transceiver_resp_req_t **preq, uint
307307
static int build_enquire_link_request(smpp_enquire_link_req_t **preq, smpp_session_t *session)
308308
{
309309
if (!preq || !session) {
310-
LM_ERR("NULL param");
310+
LM_ERR("NULL param\n");
311311
goto err;
312312
}
313313

314314
/* request allocations */
315315
smpp_enquire_link_req_t *req = pkg_malloc(sizeof(*req));
316316
*preq = req;
317317
if (!req) {
318-
LM_ERR("malloc error for request");
318+
LM_ERR("malloc error for request\n");
319319
goto err;
320320
}
321321

322322
smpp_header_t *header = pkg_malloc(sizeof(*header));
323323
if (!header) {
324-
LM_ERR("malloc error for header");
324+
LM_ERR("malloc error for header\n");
325325
goto header_err;
326326
}
327327

328328
req->payload.s = pkg_malloc(REQ_MAX_SZ(ENQUIRE_LINK));
329329
if (!req->payload.s) {
330-
LM_ERR("malloc error for payload");
330+
LM_ERR("malloc error for payload\n");
331331
goto payload_err;
332332
}
333333

@@ -599,33 +599,33 @@ static int build_submit_or_deliver_request(smpp_submit_sm_req_t **preq,
599599
char *start;
600600

601601
if (!preq || !src || !dst || !message) {
602-
LM_ERR("NULL params");
602+
LM_ERR("NULL params\n");
603603
goto err;
604604
}
605605

606606
/* request allocations */
607607
smpp_submit_sm_req_t *req = pkg_malloc(sizeof(*req));
608608
*preq = req;
609609
if (!req) {
610-
LM_ERR("malloc error for request");
610+
LM_ERR("malloc error for request\n");
611611
goto err;
612612
}
613613

614614
smpp_header_t *header = pkg_malloc(sizeof(*header));
615615
if (!header) {
616-
LM_ERR("malloc error for header");
616+
LM_ERR("malloc error for header\n");
617617
goto header_err;
618618
}
619619

620620
smpp_submit_sm_t *body = pkg_malloc(sizeof(*body));
621621
if (!body) {
622-
LM_ERR("malloc error for body");
622+
LM_ERR("malloc error for body\n");
623623
goto body_err;
624624
}
625625

626626
req->payload.s = pkg_malloc(REQ_MAX_SZ(SUBMIT_SM));
627627
if (!req->payload.s) {
628-
LM_ERR("malloc error for payload");
628+
LM_ERR("malloc error for payload\n");
629629
goto payload_err;
630630
}
631631

@@ -703,33 +703,33 @@ static int build_submit_or_deliver_request(smpp_submit_sm_req_t **preq,
703703
static int build_submit_or_deliver_resp_request(smpp_submit_sm_resp_req_t **preq, uint32_t command_id, uint32_t command_status, uint32_t sequence_number)
704704
{
705705
if (!preq) {
706-
LM_ERR("NULL param");
706+
LM_ERR("NULL param\n");
707707
goto err;
708708
}
709709

710710
/* request allocations */
711711
smpp_submit_sm_resp_req_t *req = pkg_malloc(sizeof(*req));
712712
*preq = req;
713713
if (!req) {
714-
LM_ERR("malloc error for request");
714+
LM_ERR("malloc error for request\n");
715715
goto err;
716716
}
717717

718718
smpp_header_t *header = pkg_malloc(sizeof(*header));
719719
if (!header) {
720-
LM_ERR("malloc error for header");
720+
LM_ERR("malloc error for header\n");
721721
goto header_err;
722722
}
723723

724724
smpp_submit_sm_resp_t *body = pkg_malloc(sizeof(*body));
725725
if (!body) {
726-
LM_ERR("malloc error for body");
726+
LM_ERR("malloc error for body\n");
727727
goto body_err;
728728
}
729729

730730
req->payload.s = pkg_malloc(REQ_MAX_SZ(SUBMIT_SM_RESP));
731731
if (!req->payload.s) {
732-
LM_ERR("malloc error for payload");
732+
LM_ERR("malloc error for payload\n");
733733
goto payload_err;
734734
}
735735

modules/qrouting/qr_stats.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ void qr_rld_prepare_part(void *param)
412412
memset(pl, 0, sizeof *pl);
413413

414414
if (!(pl->rw_lock = lock_init_rw())) {
415-
LM_ERR("failed to init rw lock");
415+
LM_ERR("failed to init rw lock\n");
416416
goto error;
417417
}
418418

modules/stir_shaken/stir_shaken.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -536,7 +536,7 @@ static int build_unsigned_pport(str *buf, time_t iat_ts, str *attest,
536536

537537
hdr_json_str.s = build_pport_hdr_json(cr_url);
538538
if (!hdr_json_str.s) {
539-
LM_ERR("Failed to build PASSporT's json header");
539+
LM_ERR("Failed to build PASSporT's json header\n");
540540
return -1;
541541
}
542542
hdr_json_str.len = strlen(hdr_json_str.s);
@@ -546,7 +546,7 @@ static int build_unsigned_pport(str *buf, time_t iat_ts, str *attest,
546546
payload_json_str.s = build_pport_payload_json(attest, orig_tn, dest_tn,
547547
iat_ts, origid);
548548
if (!payload_json_str.s) {
549-
LM_ERR("Failed to build PASSporT's json payload");
549+
LM_ERR("Failed to build PASSporT's json payload\n");
550550
goto error;
551551
}
552552
payload_json_str.len = strlen(payload_json_str.s);
@@ -940,7 +940,7 @@ static int w_stir_auth(struct sip_msg *msg, str *attest, str *origid,
940940
}
941941

942942
if (get_header_by_static_name(msg, "Identity")) {
943-
LM_INFO("Identity header already exists");
943+
LM_INFO("Identity header already exists\n");
944944
return -2;
945945
}
946946

0 commit comments

Comments
 (0)