Skip to content

Commit 40e53d2

Browse files
committed
tests: Use atomic integer for counter to avoid data race
1 parent 0df0230 commit 40e53d2

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

internal/generator/generator_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import (
99
"net/http"
1010
"os"
1111
"strings"
12+
"sync/atomic"
1213
"testing"
1314
"time"
1415

@@ -22,7 +23,7 @@ import (
2223
func TestGenerateFromEvents(t *testing.T) {
2324
log.SetOutput(ioutil.Discard)
2425
containerID := "8dfafdbc3a40"
25-
counter := 0
26+
var counter atomic.Int32
2627

2728
eventsResponse := `
2829
{"status":"start","id":"8dfafdbc3a40","from":"base:latest","time":1374067924}
@@ -67,7 +68,7 @@ func TestGenerateFromEvents(t *testing.T) {
6768
json.NewEncoder(w).Encode(result)
6869
}))
6970
server.CustomHandler(fmt.Sprintf("/containers/%s/json", containerID), http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
70-
counter++
71+
counter := counter.Add(1)
7172
container := docker.Container{
7273
Name: "docker-gen-test",
7374
ID: containerID,

0 commit comments

Comments
 (0)