feat: dont register productClick event if no onProductClick received

Author: Romain Julien

packages/display-react/src/index.js

@@ -22,7 +22,7 @@ function unRegisterEvent(controller, name, callbackFromRegister) {
 }
 
 const EVENTS = {
-  PRODUCT_CLICK: 'poductClick',
+  PRODUCT_CLICK: 'productClick',
   CHANGE_SCENE: 'changeScene',
   CHANGE_PRODUCT_LOCATION: 'changeSelectedProductLocation',
   LOAD_SCENE: 'loadScene',
@@ -110,14 +110,16 @@ function Display(
           onChangeSelectedProductLocationStable,
         )
         const callbackOnError = registerEvent(ctrl, EVENTS.ERROR, onErrorStable)
-        const callbackOnProductClick = registerEvent(ctrl, EVENTS.PRODUCT_CLICK, onProductClickStable)
+        const callbackOnProductClick = onProductClickStable.current ? registerEvent(ctrl, EVENTS.PRODUCT_CLICK, onProductClickStable) : undefined
         const callbackOnFilter = registerEvent(ctrl, EVENTS.FILTER, onFilterStable)
         return () => {
           unRegisterEvent(ctrl, EVENTS.LOAD_SCENE, callbackOnLoadScene)
           unRegisterEvent(ctrl, EVENTS.CHANGE_SCENE, callbackOnChangeScene)
           unRegisterEvent(ctrl, EVENTS.CHANGE_PRODUCT, callbackOnChangeProduct)
           unRegisterEvent(ctrl, EVENTS.CHANGE_PRODUCT_LOCATION, callbackOnChangeSelectedProductLocationStable)
-          unRegisterEvent(ctrl, EVENTS.PRODUCT_CLICK, callbackOnProductClick)
+          if (callbackOnProductClick) {
+            unRegisterEvent(ctrl, EVENTS.PRODUCT_CLICK, callbackOnProductClick)
+          }
           unRegisterEvent(ctrl, EVENTS.FILTER, callbackOnFilter)
           unRegisterEvent(ctrl, EVENTS.ERROR, callbackOnError)
           ctrl.current.destroy()