Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of cores calculation for Trimgalore #413

Open
PramodRaoB opened this issue Feb 25, 2025 · 1 comment
Open

Number of cores calculation for Trimgalore #413

PramodRaoB opened this issue Feb 25, 2025 · 1 comment
Labels
wontfix This will not be worked on

Comments

@PramodRaoB
Copy link

Description of the bug

As discussed in this issue, the calculation for actual number of cores used by Trimgalore is convoluted. The current calculation is present in this code. But, the actual core usage seems to be more than the number provided by task.cpus when the parameter --gzip is active with python3 and pigz available.

Breaking it down and drawing parallel to the comment by @FelixKrueger in the same thread, in the trimming section,

  • cutadapt uses cores provided by the -j argument
  • trim_galore: 1 (high)
  • write to pigz stream: 1 (low)
  • however, pigz would also use -j cores

This would mean, at least 2 * j + 1 cores for the trimming process.

The same would extend to the validation stage where due to pigz, the calculation would include additional j cores than the prior calculation.

Command used and terminal output

Relevant files

No response

System information

No response

@PramodRaoB PramodRaoB added the bug Something isn't working label Feb 25, 2025
@JoseEspinosa
Copy link
Member

This is how the nf-core module (here) is implemented please open an issue there with your comments to update the module. Thanks!

@JoseEspinosa JoseEspinosa added wontfix This will not be worked on and removed bug Something isn't working labels Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants