Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check canLeaveConversation and canDeleteConversation handling #4570

Closed
nickvergessen opened this issue Jan 2, 2025 · 0 comments · Fixed by #4627
Closed

Check canLeaveConversation and canDeleteConversation handling #4570

nickvergessen opened this issue Jan 2, 2025 · 0 comments · Fixed by #4627
Assignees
@mahibi
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) bug Something isn't working feature: 📄 conversations
Milestone
20.1.1

Comments

@nickvergessen
Copy link
Member

If the attribute canLeaveConversation is there it should be respected no matter any other things. Same for canDeleteConversation. (Required for an upcoming feature where we change those values e.g. one-to-one can no longer be left, but only deleted: nextcloud/spreed#14064 )

Also make sure that canDeleteConversation is used to determine if "Delete all message" is shown.
@nickvergessen nickvergessen added 1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) bug Something isn't working labels Jan 2, 2025
@nickvergessen nickvergessen added this to the 20.1.1 milestone Jan 2, 2025
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 💬 Talk team Jan 2, 2025
@nickvergessen nickvergessen moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 💬 Talk team Jan 2, 2025
@nickvergessen nickvergessen mentioned this issue Jan 2, 2025
Merged
10 tasks
@mahibi mahibi self-assigned this Jan 17, 2025
@mahibi mahibi mentioned this issue Jan 17, 2025
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 💬 Talk team Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mahibi mahibi

Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) bug Something isn't working feature: 📄 conversations
Projects
💬 Talk team
Status: ☑️ Done
Milestone
20.1.1
Development

Successfully merging a pull request may close this issue.

Rework can leave/delete conversation nextcloud/talk-android
2 participants
@nickvergessen @mahibi