Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how duration and exclusive duration are calculated #2695

Open
bizob2828 opened this issue Oct 31, 2024 · 3 comments
Open

Update how duration and exclusive duration are calculated #2695

bizob2828 opened this issue Oct 31, 2024 · 3 comments
Labels
points: 5 1-2 weeks semver: major Backwards incompatible changes.

Comments

@bizob2828
Copy link
Member

bizob2828 commented Oct 31, 2024

Description

We have done work to remove the transaction from the segment(#2658). We are still attaching the root segment to every segment so it can update the exclusive time. Instead of having every segment update the root with a new time, I think we can just update the code to capture relative start/end times from its parent.

@bizob2828 bizob2828 added the points: 5 1-2 weeks label Oct 31, 2024
@workato-integration
Copy link

@bizob2828
Copy link
Member Author

this is causing issues with losing context at times. I'm going to put this on the backlog

@bizob2828 bizob2828 removed their assignment Nov 4, 2024
@bizob2828 bizob2828 changed the title Move root segment to context manager Update how duration and exclusive duration are calculated Nov 12, 2024
@kmudduluru kmudduluru moved this from Triage Needed: Unprioritized Features to Prioritized in Node.js Engineering Board Dec 9, 2024
@bizob2828 bizob2828 moved this from Prioritized to Triage Needed: Unprioritized Features in Node.js Engineering Board Dec 12, 2024
@bizob2828 bizob2828 moved this from Triage Needed: Unprioritized Features to Prioritized in Node.js Engineering Board Dec 12, 2024
@jsumners-nr jsumners-nr moved this from Prioritized to In progress: Issues being worked on in Node.js Engineering Board Dec 30, 2024
@bizob2828 bizob2828 added the semver: major Backwards incompatible changes. label Jan 2, 2025
@jsumners-nr
Copy link
Contributor

I think it is best to put this on hold for now. The duration timings are very tightly ingrained in the instrumentation flows. It will take some significant research to determine how they are currently handled in order to determine how to refactor them. I believe this is a bit too disruptive given the other significant refactoring we already have queued up for release.

@jsumners-nr jsumners-nr moved this from In progress: Issues being worked on to Triage Needed: Unprioritized Features in Node.js Engineering Board Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
points: 5 1-2 weeks semver: major Backwards incompatible changes.
Projects
Status: Triage Needed: Unprioritized Features
Development

No branches or pull requests

2 participants