Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Side Configuration should override application_logging environment variables #2174

Open
arenjae opened this issue Dec 18, 2024 · 2 comments

Comments

@arenjae
Copy link

arenjae commented Dec 18, 2024

Description

Currently, if application_logging settings are returned from server side configuration (beta), but an environment variable overrides the setting, ie:

ENV NEW_RELIC_APPLICATION_LOGGING_ENABLED=false

or

ENV NEW_RELIC_APPLICATION_LOGGING_FORWARDING_ENABLED=false

the server side configuration is not overriding the environment variable.

Acceptance Criteria

As a user, if I enable server side configuration, and set application_logging.enabled=true, but locally for my agent I have ENV NEW_RELIC_APPLICATION_LOGGING_ENABLED=false defined, my agent will use the server side configuration instead of the environment variable, and forward the application logs.

Design Consideration/Limitations

This is supported for other server side configuration settings.

Dependencies

n/a

Additional context

This is related to a new feature to enable server side configuration for application_logging

@workato-integration
Copy link

@jasonjkeller
Copy link
Contributor

When testing this functionality it is advised to use an APM staging account as support for application logging config via server side will be rolled out there before prod. If you have any questions reach out to me or rjohnson on slack.

As of Dec 18th 2024:

I think it will be rolled out 100% in staging on Thursday
20% in prod on Friday
So if they want to test in prod there is a feature flag to allow enabling in the UI
However right now we are hiding the UI if the environment variables are there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants