Skip to content

Commit 98bb204

Browse files
author
Aaron Long
committed
Fix #29: Resolve code review feedback
1 parent 92b8f0d commit 98bb204

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

core/src/main/java/com/newrelic/logging/core/ExceptionUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public static String getErrorStack(StackTraceElement[] stack, Integer maxStackSi
2525
return null;
2626
}
2727

28-
StringBuilder stackBuilder = new StringBuilder(maxStackSize);
28+
StringBuilder stackBuilder = new StringBuilder();
2929
for(int i = 0; i < Math.min(maxStackSize, stack.length); i++) {
3030
stackBuilder.append(" at " + stack[i].toString() + "\n");
3131
}

logback/src/main/java/com/newrelic/logging/logback/NewRelicEncoder.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
public class NewRelicEncoder extends EncoderBase<ILoggingEvent> {
3333
private NewRelicJsonLayout layout;
3434

35-
Integer maxStackSize = MAX_STACK_SIZE;
35+
private Integer maxStackSize = MAX_STACK_SIZE;
3636

3737
@Override
3838
public byte[] encode(ILoggingEvent event) {
@@ -53,6 +53,10 @@ public void start() {
5353
layout.start();
5454
}
5555

56+
public void setMaxStackSize(final Integer maxStackSize) {
57+
this.maxStackSize = maxStackSize;
58+
}
59+
5660
@Override
5761
public byte[] headerBytes() {
5862
return new byte[0];

logback/src/main/java/com/newrelic/logging/logback/NewRelicJsonLayout.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import static com.newrelic.logging.core.ExceptionUtil.MAX_STACK_SIZE;
2424

2525
public class NewRelicJsonLayout extends LayoutBase<ILoggingEvent> {
26-
private Integer maxStackSize;
26+
private final Integer maxStackSize;
2727

2828
public NewRelicJsonLayout() {
2929
this(MAX_STACK_SIZE);

0 commit comments

Comments
 (0)